Support Importing Volume Over HTTP Using Basic Auth #1878
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: moadqassem <[email protected]>
Signed-off-by: moadqassem <[email protected]>
kubermatic-bot
added
release-note
Signed-off-by: moadqassem <[email protected]>
|
LGTM label has been added. Git tree hash: faa2557f26c3f54301c7db799a3ed7242b2989bd
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cnvergence The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubermatic-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
One way to import a a virtual machine disk, is via an http endpoint that holds a raw image. So far this method didn't support basic auth to interact with the image repo server that holds these raw images. This PR supports sending the basic auth as a header in the CDI DataVolume object by reading the headers either explicitly from the Machine Deployment spec or referring to a secret that contains those headers.
ExtraHeadersfield in the MachineDeployment spec is used to read those headers explicitly and send them as part of the importing request.ExtraHeadersFromSecretis used to read those headers from a secret that is being referenced in the MachineDeployment object.Which issue(s) this PR fixes:
/kind feature
Fixes #
What type of PR is this?
Special notes for your reviewer:
This PR has been tested manually and it succeeded.
Does this PR introduce a user-facing change? Then add your Release Note here:
Documentation: