Skip to content

feat(metrics): add machine deployment metrics #1879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

rajaSahil
Copy link
Contributor

@rajaSahil rajaSahil commented Nov 19, 2024

What this PR does / why we need it:

  • add machine deployment metrics
# HELP machine_deployment_available_replicas The number of available replicas for a machine deployment
# TYPE machine_deployment_available_replicas gauge
machine_deployment_available_replicas{name="",namespace=""} 0
# HELP machine_deployment_ready_replicas The number of ready replicas for a machine deployment
# TYPE machine_deployment_ready_replicas gauge
machine_deployment_ready_replicas{name="",namespace=""} 0
# HELP machine_deployment_replicas The number of replicas defined for a machine deployment
# TYPE machine_deployment_replicas gauge
machine_deployment_replicas{name="",namespace=""} 0
# HELP machine_deployment_updated_replicas The number of replicas updated for a machine deployment
# TYPE machine_deployment_updated_replicas gauge
machine_deployment_updated_replicas{name="",namespace=""} 0

Which issue(s) this PR fixes:

Fixes #1767

What type of PR is this?
/kind feature

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

 Add collector to expose machine deployment metrics

Documentation:

NONE

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. docs/provided Denotes a PR that has a valid documentation reference. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 19, 2024
@rajaSahil
Copy link
Contributor Author

/assign @embik

@kubermatic-bot kubermatic-bot added docs/none Denotes a PR that doesn't need documentation (changes). and removed docs/provided Denotes a PR that has a valid documentation reference. labels Nov 19, 2024
@embik
Copy link
Member

embik commented Jan 6, 2025

@rajaSahil did you see the linter errors?

Signed-off-by: rajaSahil <[email protected]>
@rajaSahil rajaSahil force-pushed the add-machinedeployment-metrics branch from 2cee2d6 to 1c8ac03 Compare January 12, 2025 17:21
@rajaSahil
Copy link
Contributor Author

@embik Please re-review, have fixed lint errors.

@rajaSahil rajaSahil requested a review from embik January 22, 2025 07:15
Copy link
Member

@embik embik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 22, 2025
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 394dad768e8cd55e713a510c3c533fd08e541c5a

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: embik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2025
@kubermatic-bot kubermatic-bot merged commit cb06308 into kubermatic:main Jan 22, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose metrics for MachineDeployment status
3 participants