Skip to content

Refactor Ubuntu ARM image in AWS #1880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 20, 2024
Merged

Refactor Ubuntu ARM image in AWS #1880

merged 1 commit into from
Nov 20, 2024

Conversation

moadqassem
Copy link
Member

@moadqassem moadqassem commented Nov 19, 2024 •
edited
Loading

What this PR does / why we need it:
Update ubuntu 24.04 arm image in aws
Which issue(s) this PR fixes:

Fixes #

What type of PR is this?
/kind bug

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

None

Documentation:

None

@kubermatic-bot kubermatic-bot added dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/docs-needed Indicates that a PR should not merge because it's missing one of the documentation labels. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. docs/none Denotes a PR that doesn't need documentation (changes). and removed do-not-merge/docs-needed Indicates that a PR should not merge because it's missing one of the documentation labels. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 19, 2024
@moadqassem
Copy link
Member Author

/hod would like to do one last test

ahmedwaleedmalik
ahmedwaleedmalik approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@moadqassem can you please add a release note if this is a bug? Also, do we need to backport this?

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 20, 2024
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8102e7654189bb7a69cc36ffa2c834c66193a3fc

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 20, 2024
@kubermatic-bot kubermatic-bot merged commit 63ed9f0 into kubermatic:main Nov 20, 2024
12 checks passed
@ahmedwaleedmalik
Copy link
Member

Umm what, I thought it was on hold

/hod would like to do one last test

So a typo there, we can use a follow-up PR if required

@moadqassem
Copy link
Member Author

Umm what, I thought it was on hold

/hod would like to do one last test

So a typo there, we can use a follow-up PR if required

All good :D I mean it should work as I tested it briefly but I had issues with my testing cluster(cni ;) ) I will bump machine controller in KKP main and KKP 2.26 now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedwaleedmalik ahmedwaleedmalik ahmedwaleedmalik approved these changes

Assignees

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@moadqassem @kubermatic-bot @ahmedwaleedmalik