-
Notifications
You must be signed in to change notification settings - Fork 135
Add ClusterNamespace Annotations to Worker Nodes #1924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ClusterNamespace Annotations to Worker Nodes #1924
Conversation
Signed-off-by: moadqassem <[email protected]> Signed-off-by: moadqassem <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
LGTM label has been added. Git tree hash: 7e853868d6451ccf5e74eab41a370889de1c07bb
|
/retest |
/hold |
Signed-off-by: moadqassem <[email protected]>
a757c33
to
3d52a68
Compare
/unhold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
LGTM label has been added. Git tree hash: 935aac9c1ff02e482f9c7f5374d09fe531cbc4a1
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kron4eg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherrypick release/v1.61 |
@moadqassem: #1924 failed to apply on top of branch "release/v1.61":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
* add clusterNamespace annotations * initialize annotation Signed-off-by: moadqassem <[email protected]> (cherry picked from commit 7a93ac5) Signed-off-by: moadqassem <[email protected]>
* add clusterNamespace annotations * initialize annotation (cherry picked from commit 7a93ac5) Signed-off-by: moadqassem <[email protected]>
* add clusterNamespace annotations * initialize annotation (cherry picked from commit 7a93ac5) Signed-off-by: moadqassem <[email protected]>
What this PR does / why we need it:
The new KubeVirt CSI driver expects the tenant cluster nodes should have an annotation that determines the tenant cluster namespace in the infra cluster. This PR reads the namespace value from the machine deployment spec and adds it to the node annotations.
Which issue(s) this PR fixes:
Fixes #
What type of PR is this?
/kind chore
Special notes for your reviewer:
Does this PR introduce a user-facing change? Then add your Release Note here:
Documentation: