Skip to content

ci: update action versions, test node 23, unpin node 20 #2059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Nov 26, 2024

This commit does the following:

  • Updates actions/checkout and actions/setup-node to v4 to avoid warning annotations when the test suite runs.
  • Adds Node v23 to the testing matrix since this is presently the Current release line.
  • Unpins the Node 20 version. The referenced GitHub issue is still open, but the tests seem to pass now.

The formatting happened automatically. I didn't do that.

This commit does the following:

- Updates actions/checkout and actions/setup-node to v4 to
  avoid warning annotations when the test suite runs.
- Adds Node v23 to the testing matrix since this is presently
  the Current release line.
- Unpins the Node 20 version. The referenced GitHub issue is
  still open, but the tests seem to pass now.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 26, 2024
@mstruebing
Copy link
Member

/lgtm
/approve

Thanks 🚀

Yeah the formatter stopped working for some time and just recently got reintroduced again.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 26, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cjihrig, mstruebing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 26, 2024
@k8s-ci-robot k8s-ci-robot merged commit 3c81be4 into kubernetes-client:release-1.x Nov 26, 2024
7 of 8 checks passed
@cjihrig cjihrig deleted the ci-updates branch November 26, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants