-
Notifications
You must be signed in to change notification settings - Fork 544
Proxy url #2091
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proxy url #2091
Conversation
Welcome @krmodelski! |
/easycla |
This looks good to me, thanks for adding tests. Once this merges, you may want to cherry-pick it into the |
Code looks good to me as well, I did not test it though. |
@mstruebing I'm personally ok to merge w/o e2e testing. I'm confident that this won't break anyone who doesn't have wdyt? |
Sounds good, considering that this is a new feature it shouldn't break anything you are right. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: krmodelski, mstruebing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Add http/https and socks proxy support