deploy: replace /var/lib/kubelet on-the-fly

[pohly]

What type of PR is this?
/kind feature

What this PR does / why we need it:

This is useful for clusters where kubelet is installed
differently. KinD cluster testing might be done with a non-default
location to recognize and cleanup loop devices that were set up by
the driver.

Which issue(s) this PR fixes:
Fixes #71

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

/var/lib/kubelet will be replaced on-the-fly by the deploy.sh scripts with the content of the KUBELET_DATA_DIR env variable.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [pohly]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jsafrane]

It's probably matter of style, would it be better to have somewhere on the top:

KUBELET_DATA_DIR=${KUBELET_DATA_DIR:-/var/lib/kubelet}

and then use $KUBELET_DATA_DIR without extra expansion, especially when part of a regexp here?

[pohly]

Yes, that may be a bit more obvious. I'll change it.

[pohly]

Done and pushed.

[jsafrane]

/retest

[msau42]

Longer term, I think it would be easier to maintain customization logic like this if we move to a templating tool like kustomize

…

On Mon, May 10, 2021, 08:42 Jan Šafránek ***@***.***> wrote: /retest — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#286 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AF2QYPISVOVDQ4NDPWPXF23TM75FNANCNFSM44FODKIA> .

[pohly]

Longer term, I think it would be easier to maintain customization logic like this if we move to a templating tool like kustomize

I agree, but this is a significant change and some of the things we currently do in shell code (like taking parameters via env variables) will not be straight-forward. So unless we find someone with significant time at his hand I suspect we'll have to stick with what we have.

[jsafrane]

/lgtm

[k8s-ci-robot]

@pohly: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
pull-kubernetes-csi-csi-driver-host-path-1-21-on-kubernetes-1-21	89ae426	link	/test pull-kubernetes-csi-csi-driver-host-path-1-21-on-kubernetes-1-21
pull-kubernetes-csi-csi-driver-host-path-1-21-test-on-kubernetes-1-21	89ae426	link	/test pull-kubernetes-csi-csi-driver-host-path-1-21-test-on-kubernetes-1-21

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[pohly]

/retest