volume lifecycle fixes #292
Conversation
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
approved
pohly
force-pushed
the
volume-lifecycle-fixes
branch
from
72cd882 to
4ade042
Compare
The recently introduced support for tracking of staging and publishing can be improved: - Now it properly supports publishing more than once. - Mutex locking in NodeStageVolume and NodeUnstageVolume was missing. - NodeUnstageVolume and NodeUnpublishVolume can bail out early when nothing needs to be done. In the case of NodeUnpublishVolume that avoids unmounting at a path not managed by the driver. The driver cannot distinguish between an invalid path and an idempotent call, so this is not treated as an error. - NodePublishVolume checks that the staging target path is valid. - NodeStageVolume rejects staging more than once.
pohly
force-pushed
the
volume-lifecycle-fixes
branch
from
4ade042 to
f2b48cd
Compare
|
@avalluri : can you perhaps review? |
| IsAttached bool | ||
| IsStaged bool | ||
| IsPublished bool | ||
| Attached bool |
There was a problem hiding this comment.
I removed the Is prefix for consistency with the other booleans and because it no longer works for the fields that aren't a boolean anymore.
|
@pohly: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: avalluri, pohly The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
The recently introduced support for tracking of staging and publishing can be improved:
when nothing needs to be done. In the case of NodeUnpublishVolume
that avoids unmounting at a path not managed by the driver. The
driver cannot distinguish between an invalid path and an idempotent
call, so this is not treated as an error.
Which issue(s) this PR fixes:
Fixes #290
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
The code that gets enhanced was in no prior release, therefore we don't need to mention this change.