Skip to content

feat: support mountOptions parameter in VolumeSnapshotClass #879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 18, 2025
Merged

feat: support mountOptions parameter in VolumeSnapshotClass #879

merged 1 commit into from
Mar 18, 2025

Conversation

@andyzhangx
Copy link
Member

What type of PR is this?
/kind feature

What this PR does / why we need it:
feat: support mountOptions parameter in VolumeSnapshotClass

Which issue(s) this PR fixes:

Fixes #861

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

feat: support mountOptions parameter in VolumeSnapshotClass

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Mar 17, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 17, 2025
@andyzhangx andyzhangx force-pushed the snapshot-mountOptions branch from 4ccb5bb to b42674e Compare March 17, 2025 09:10
@andyzhangx andyzhangx mentioned this pull request Mar 17, 2025
Closed
@coveralls
Copy link

coveralls commented Mar 17, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 13895608644

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.7%) to 78.178%
Totals Coverage Status
Change from base Build 13893596329: 0.7%
Covered Lines: 1107
Relevant Lines: 1416
💛 - Coveralls

@andyzhangx andyzhangx merged commit f19cd2a into kubernetes-csi:master Mar 18, 2025
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jingxu97 jingxu97 Awaiting requested review from jingxu97

@RaunakShah RaunakShah Awaiting requested review from RaunakShah

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

NFS mount options ignored by CSI in Volume Snapshot request

3 participants

@andyzhangx @k8s-ci-robot @coveralls