Moving nil check to correct location #279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
Contributor
|
Hi @huffmanca. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
needs-ok-to-test
k8s-ci-robot
added
the
size/XS
Collaborator
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
Collaborator
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: huffmanca, xing-yang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Aishwarya-Hebbar
added a commit
to Aishwarya-Hebbar/external-snapshotter
that referenced
this pull request
Jul 7, 2025
74e066a82 Merge pull request kubernetes-csi#279 from Aishwarya-Hebbar/update-csi-prow-version 6f236be7d Update CSI prow driver version to v1.17.0 0ee55894b Merge pull request kubernetes-csi#280 from xing-yang/update_go_1.24.4 9af101534 update to go 1.24.4 f5fec3e36 Merge pull request kubernetes-csi#275 from chrishenzie/emeritus c5d285db8 Remove chrishenzie from kubernetes-csi-reviewers 0a435bf98 Merge pull request kubernetes-csi#274 from andyzhangx/patch-5 cd7b4bba3 Bump golang to 1.24.2 to fix CVE-2025-22871 701dc34bc Merge pull request kubernetes-csi#273 from andyzhangx/patch-4 aeebd30e8 Bump golang to 1.24.0 f277d561f Merge pull request kubernetes-csi#270 from carlory/update-kind-version 6dcb96a51 update default kind version to v0.25.0 git-subtree-dir: release-tools git-subtree-split: 74e066a82d2ea14a68ff37f0e02ddc34619bbccd
Aishwarya-Hebbar
added a commit
to Aishwarya-Hebbar/external-snapshotter
that referenced
this pull request
Jul 8, 2025
74e066a82 Merge pull request kubernetes-csi#279 from Aishwarya-Hebbar/update-csi-prow-version 6f236be7d Update CSI prow driver version to v1.17.0 0ee55894b Merge pull request kubernetes-csi#280 from xing-yang/update_go_1.24.4 9af101534 update to go 1.24.4 f5fec3e36 Merge pull request kubernetes-csi#275 from chrishenzie/emeritus c5d285db8 Remove chrishenzie from kubernetes-csi-reviewers 0a435bf98 Merge pull request kubernetes-csi#274 from andyzhangx/patch-5 cd7b4bba3 Bump golang to 1.24.2 to fix CVE-2025-22871 701dc34bc Merge pull request kubernetes-csi#273 from andyzhangx/patch-4 aeebd30e8 Bump golang to 1.24.0 f277d561f Merge pull request kubernetes-csi#270 from carlory/update-kind-version 6dcb96a51 update default kind version to v0.25.0 git-subtree-dir: release-tools git-subtree-split: 74e066a82d2ea14a68ff37f0e02ddc34619bbccd
dobsonj
added a commit
to dobsonj/external-snapshotter
that referenced
this pull request
Sep 4, 2025
5f38a9075 Merge pull request kubernetes-csi#282 from rhrmo/update-go-1.24.6 579f62421 Update go to 1.24.6 74e066a82 Merge pull request kubernetes-csi#279 from Aishwarya-Hebbar/update-csi-prow-version 6f236be7d Update CSI prow driver version to v1.17.0 0ee55894b Merge pull request kubernetes-csi#280 from xing-yang/update_go_1.24.4 9af101534 update to go 1.24.4 f5fec3e36 Merge pull request kubernetes-csi#275 from chrishenzie/emeritus c5d285db8 Remove chrishenzie from kubernetes-csi-reviewers git-subtree-dir: release-tools git-subtree-split: 5f38a907597230563f5e2213aea116acdd9d86bc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Moves the nil check on VolumeSnapshotContent to the correct location.
Does this PR introduce a user-facing change?: