Skip to content
This repository was archived by the owner on Dec 3, 2024. It is now read-only.

Update Makefile #66

Merged
merged 1 commit into from
Sep 15, 2022
Merged

Update Makefile #66

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,4 +28,3 @@ CMDS=controller-manager
include release-tools/build.make

IMAGE_NAME=gcr.io/k8s-staging-sig-storage/objectstorage-controller
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
IMAGE_NAME=gcr.io/k8s-staging-sig-storage/objectstorage-controller
IMAGE_NAME=gcr.io/k8s-staging-sig-storage/objectstorage-controller
IMAGE_TAGS=$(TAG)

I tried running, but while it did build and push correctly, it still gave the canary tag. I think what is happening is that the tag we want is not being added, and that build.make creates a canary image by default since no tag is found. IMAGE_TAGS is needed to add a new image, so either we could just type in our tag there, or if we need to get it from cloudbuild.yaml, replace the push arg in line 18 of cloudbuild.yaml with args: ['push', 'TAG=${_GIT_TAG}'] and commit the above changes. This will make it so cloudbuild calls push with the tag as an argument, and have the makefile accept it and add it to the tags.

IMAGE_TAGS=canary