Skip to content

disk: allow unpublish pci-pf-stub driver#1582

Merged
k8s-ci-robot merged 1 commit into
kubernetes-sigs:masterfrom
huww98:pci-pf-stub
Dec 24, 2025
Merged

disk: allow unpublish pci-pf-stub driver#1582
k8s-ci-robot merged 1 commit into
kubernetes-sigs:masterfrom
huww98:pci-pf-stub

Conversation

@huww98

@huww98 huww98 commented Dec 10, 2025

Copy link
Copy Markdown
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Fix failing NodeUnpublishVolume for runD pods if the disk is already detached from controller

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Dec 10, 2025
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 10, 2025
@mowangdk

Copy link
Copy Markdown
Contributor

I believe this may not be sufficient. Could it affect the disk newly attached to this node?

@huww98

huww98 commented Dec 12, 2025

Copy link
Copy Markdown
Contributor Author

This code is in umountRunDVolumes, which is only called in unpublish.

@mowangdk

Copy link
Copy Markdown
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 24, 2025
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: huww98, mowangdk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit e2ea30f into kubernetes-sigs:master Dec 24, 2025
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants