nas: pass along context to rate limiter#1583
Merged
Merged
Conversation
k8s-ci-robot
added
the
kind/cleanup
k8s-ci-robot
added
size/XL
huww98
force-pushed
the
nas-ctx
branch
2 times, most recently
from
c28d6c0 to
19a084e
Compare
k8s-ci-robot
added
size/XXL
Allow us to add more context to the "GRPC call start" related log entry.
Extract request ID, Error code from response or error for logging. Transform the error for k8s event. - Do not include anything that changes at each request (e.g. RequestID) in error message, for better event aggregation. RequestID is still present in the log. - Support using errors.Is() for checking error code programmatically.
k8s-ci-robot
added
size/XL
and use new wrap package
Sometime explicit is better, and sometimes we add field name for consistency.
k8s-ci-robot
added
size/XXL
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Contributor
|
/approve |
mowangdk
reviewed
Mar 16, 2026
| Header: http.Header{}, | ||
| Body: io.NopCloser(bytes.NewReader(jsonBytes)), | ||
| Header: http.Header{ | ||
| "X-Acs-Request-Id": []string{"testing-openapi-request-id"}, |
Contributor
Author
There was a problem hiding this comment.
Used in unit-test to verify that we can capture the request-ID to the log output.
Contributor
|
/approve We currently lack sufficient test coverage for the csi-agent scenario. We need to implement additional test cases to ensure stability when updating the csi-agent image. |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: huww98, iltyty, mowangdk The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Contributor
|
cc @iltyty |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: