-
Notifications
You must be signed in to change notification settings - Fork 836
Allow customizing AMI of eksctl Linux/Windows nodes #2459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2ed930d
to
9bb5868
Compare
Code Coverage DiffThis PR does not change the code coverage |
Signed-off-by: Connor Catlett <[email protected]>
9bb5868
to
a3c4005
Compare
@@ -30,15 +30,18 @@ iam: | |||
ebsCSIController: true | |||
managedNodeGroups: | |||
- name: ng-linux | |||
amiFamily: AmazonLinux2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't this make it so the a1compat test will no longer be able to be run as it uses al2 as a1 instance types are incompatible with al2023 https://docs.aws.amazon.com/linux/al2023/ug/ec2.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, you're right, we'll need to override specifically for that test - I'll update prow-e2e.sh
in the next revision
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind feature
What is this PR about? / Why do we need it?
This PR adds the ability to customize the AMI of linux and windows nodes in
make cluster/create
(foreksctl
only atm).How was this change tested?
Does this PR introduce a user-facing change?