Skip to content

Allow customizing AMI of eksctl Linux/Windows nodes #2459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ConnorJC3
Copy link
Contributor

@ConnorJC3 ConnorJC3 commented May 1, 2025

What type of PR is this?

/kind feature

What is this PR about? / Why do we need it?

This PR adds the ability to customize the AMI of linux and windows nodes in make cluster/create (for eksctl only atm).

How was this change tested?

$ export CLUSTER_TYPE=eksctl  
$ export WINDOWS=true  
$ export LINUX_AMI=ami-AMI_ID_HERE
$ export WINDOWS_AMI=ami-AMI_ID_HERE
$ make cluster/create

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 1, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign andrewsirenko for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from AndrewSirenko May 1, 2025 19:45
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 1, 2025
@k8s-ci-robot k8s-ci-robot requested a review from torredil May 1, 2025 19:45
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 1, 2025
@ConnorJC3 ConnorJC3 force-pushed the eksctl-custom-ami branch from 2ed930d to 9bb5868 Compare May 1, 2025 19:45
Copy link

github-actions bot commented May 1, 2025

Code Coverage Diff

This PR does not change the code coverage

@ConnorJC3 ConnorJC3 force-pushed the eksctl-custom-ami branch from 9bb5868 to a3c4005 Compare May 20, 2025 17:18
@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label May 20, 2025
@ConnorJC3 ConnorJC3 changed the title [WIP] Allow customizing AMI of eksctl Linux/Windows nodes Allow customizing AMI of eksctl Linux/Windows nodes May 20, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 20, 2025
@@ -30,15 +30,18 @@ iam:
ebsCSIController: true
managedNodeGroups:
- name: ng-linux
amiFamily: AmazonLinux2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't this make it so the a1compat test will no longer be able to be run as it uses al2 as a1 instance types are incompatible with al2023 https://docs.aws.amazon.com/linux/al2023/ug/ec2.html

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you're right, we'll need to override specifically for that test - I'll update prow-e2e.sh in the next revision

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 18, 2025
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants