-
Notifications
You must be signed in to change notification settings - Fork 300
Migrate info logging to contextual logging #9664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate info logging to contextual logging #9664
Conversation
|
Welcome @Suirenka! |
|
Hi @Suirenka. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@anndono please squash the commits, it contains merge commits. |
ba5d1e0 to
0edc086
Compare
0edc086 to
2546e80
Compare
2546e80 to
280a98b
Compare
|
/ok-to-test |
|
Please fix the linting error. |
|
/retest |
tests/e2e/utils/kustoIngest.go
Outdated
| "github.com/Azure/azure-kusto-go/azkustoingest" | ||
|
|
||
| "k8s.io/klog/v2" | ||
| "sigs.k8s.io/cloud-provider-azure/pkg/log" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please fix the ci failure:
sigs.k8s.io/cloud-provider-azure/tests/e2e/utils
utils/log.go:31:6: log already declared through import of package log ("sigs.k8s.io/cloud-provider-azure/pkg/log")
utils/kustoIngest.go:29:2: other declaration of log
b4ae389 to
5888885
Compare
|
/retest |
|
related: #1575 |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anndono, nilo19 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR partially standardizes logging practices by migrating some mixed plain-text and structural logging to contextual logging.
Changes:
klog.Infof/klog.Info/klog.InfoSwithlogger.Infofor contextual loggingWhich issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: