Skip to content

Conversation

@anndono
Copy link
Contributor

@anndono anndono commented Nov 21, 2025

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This PR partially standardizes logging practices by migrating some mixed plain-text and structural logging to contextual logging.

Changes:

  • Replaced many occurrences of: klog.Infof/klog.Info/klog.InfoS with logger.Info for contextual logging

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Nov 21, 2025
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 21, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Nov 21, 2025
@github-actions github-actions bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Nov 21, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @Suirenka!

It looks like this is your first PR to kubernetes-sigs/cloud-provider-azure 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cloud-provider-azure has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 21, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @Suirenka. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/contains-merge-commits cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 21, 2025
@nilo19
Copy link
Contributor

nilo19 commented Nov 21, 2025

@anndono please squash the commits, it contains merge commits.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 23, 2025
@anndono anndono force-pushed the chengan/migrate-to-contextual-logging-info branch from ba5d1e0 to 0edc086 Compare November 24, 2025 00:30
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 24, 2025
@anndono anndono force-pushed the chengan/migrate-to-contextual-logging-info branch from 0edc086 to 2546e80 Compare November 24, 2025 00:40
@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. and removed do-not-merge/contains-merge-commits cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 24, 2025
@anndono anndono force-pushed the chengan/migrate-to-contextual-logging-info branch from 2546e80 to 280a98b Compare November 24, 2025 00:42
@nilo19 nilo19 closed this Nov 24, 2025
@nilo19 nilo19 reopened this Nov 24, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 24, 2025
@nilo19
Copy link
Contributor

nilo19 commented Nov 24, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 24, 2025
@nilo19
Copy link
Contributor

nilo19 commented Nov 24, 2025

Please fix the linting error.

@anndono
Copy link
Contributor Author

anndono commented Nov 24, 2025

/retest

"github.com/Azure/azure-kusto-go/azkustoingest"

"k8s.io/klog/v2"
"sigs.k8s.io/cloud-provider-azure/pkg/log"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix the ci failure:

sigs.k8s.io/cloud-provider-azure/tests/e2e/utils

utils/log.go:31:6: log already declared through import of package log ("sigs.k8s.io/cloud-provider-azure/pkg/log")
utils/kustoIngest.go:29:2: other declaration of log

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 25, 2025
@anndono anndono force-pushed the chengan/migrate-to-contextual-logging-info branch from b4ae389 to 5888885 Compare November 26, 2025 04:46
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 26, 2025
@nilo19
Copy link
Contributor

nilo19 commented Nov 27, 2025

/retest

@nilo19
Copy link
Contributor

nilo19 commented Nov 27, 2025

related: #1575

@nilo19
Copy link
Contributor

nilo19 commented Nov 28, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 28, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anndono, nilo19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 28, 2025
@k8s-ci-robot k8s-ci-robot merged commit 98a8bc6 into kubernetes-sigs:master Nov 28, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants