Need to update admissionregistration version from v1beta1 to v1

[wfernandes]

What steps did you take and what happened:

1. Updated my kind, kubectl and clusterctl versions to the latest. For clusterctl, I pulled the latest code for cluster-api and did make clusterctl.
2. Created a management cluster with verbose logging on. clusterctl init --infrastructure aws -v10
3. Saw the warning logs below for our admissionregistration.k8s.io/v1beta1

What did you expect to happen:
No warnings to show up.

Anything else you would like to add:

Creating Issuer="capi-kubeadm-bootstrap-selfsigned-issuer" Namespace="capi-webhook-system"
W1013 10:00:00.003796   18812 warnings.go:67] admissionregistration.k8s.io/v1beta1 ValidatingWebhookConfiguration is deprecated in v1.16+, unavailable in v1.22+; use admissionregistration.k8s.io/v1 ValidatingWebhookConfiguration
Creating ValidatingWebhookConfiguration="capi-kubeadm-bootstrap-validating-webhook-configuration"
W1013 10:00:00.071051   18812 warnings.go:67] admissionregistration.k8s.io/v1beta1 ValidatingWebhookConfiguration is deprecated in v1.16+, unavailable in v1.22+; use admissionregistration.k8s.io/v1 ValidatingWebhookConfiguration
Creating instance objects Provider="bootstrap-kubeadm" Version="v0.3.10" TargetNamespace="capi-kubeadm-bootstrap-system"
.
.
.
Installing Provider="control-plane-kubeadm" Version="v0.3.10" TargetNamespace="capi-kubeadm-control-plane-system"
Creating shared objects Provider="control-plane-kubeadm" Version="v0.3.10"
Creating CustomResourceDefinition="kubeadmcontrolplanes.controlplane.cluster.x-k8s.io"
W1013 10:00:00.813159   18812 warnings.go:67] admissionregistration.k8s.io/v1beta1 MutatingWebhookConfiguration is deprecated in v1.16+, unavailable in v1.22+; use admissionregistration.k8s.io/v1 MutatingWebhookConfiguration
Creating MutatingWebhookConfiguration="capi-kubeadm-control-plane-mutating-webhook-configuration"
W1013 10:00:00.821344   18812 warnings.go:67] admissionregistration.k8s.io/v1beta1 MutatingWebhookConfiguration is deprecated in v1.16+, unavailable in v1.22+; use admissionregistration.k8s.io/v1 MutatingWebhookConfiguration

Environment:

• Cluster-api version: b4cb2fc
• Minikube/KIND version: kind v0.9.0 go1.15.2 darwin/amd64
• Kubernetes version: (use kubectl version):

Client Version: version.Info{Major:"1", Minor:"19", GitVersion:"v1.19.2", GitCommit:"f5743093fd1c663cb0cbc89748f730662345d44d", GitTreeState:"clean", BuildDate:"2020-09-16T21:51:49Z", GoVersion:"go1.15.2", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"19", GitVersion:"v1.19.1", GitCommit:"206bcadf021e76c27513500ca24182692aabd17e", GitTreeState:"clean", BuildDate:"2020-09-14T07:30:52Z", GoVersion:"go1.15", Compiler:"gc", Platform:"linux/amd64"}

• OS (e.g. from /etc/os-release):

/kind bug
/area api

[vincepri]

This needs changes in controller runtime, which haven't been worked on yet

[wfernandes]

If this is something that we want to fix, I'd like to take it on. Please let me know if there is anything other than upgrading the versions from v1beta1 to v1 that needs to be done.
/assign

[wfernandes]

This needs changes in controller runtime, which haven't been worked on yet

Thanks @vincepri. Does it make sense to keep this issue open?

[vincepri]

See kubernetes-sigs/controller-runtime#1161

[vincepri]

Yes, let's keep it open and track it

/milestone v0.4.0

[wfernandes]

/unassign

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[vincepri]

/lifecycle frozen

[fabriziopandini]

@vincepri IMO this one could be closed given that we are using admissionregistration.k8s.io/v1

cluster-api/config/webhook/manifests.yaml

Line 3 in e9cacc0

apiVersion: admissionregistration.k8s.io/v1

and the controller runtime work seems completed

[fabriziopandini]

/priority important-soon

[vincepri]

/close

[k8s-ci-robot]

@vincepri: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.