🐛 Ensure all pointer status fields are dereferenced correctly#12412
Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom Jun 26, 2025
Merged
🐛 Ensure all pointer status fields are dereferenced correctly#12412k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
Conversation
k8s-ci-robot
added
cncf-cla: yes
Member
Author
|
/assign @fabriziopandini @Karthik-K-N |
k8s-ci-robot
added
the
size/S
| v.replicas = fmt.Sprintf("%d/%d", *obj.Spec.Replicas, ptr.Deref(obj.Status.Replicas, 0)) | ||
| } | ||
| if obj.Status.ReadyReplicas != nil { | ||
| if obj.Status.AvailableReplicas != nil { |
k8s-ci-robot
added
the
lgtm
Contributor
|
LGTM label has been added. DetailsGit tree hash: cd06e62d84d7cc3fcc64330fec5c026159c4b7c0 |
Karthik-K-N
reviewed
Jun 26, 2025
Contributor
Karthik-K-N
left a comment
Karthik-K-N
left a comment
There was a problem hiding this comment.
I could have handled it, Missed to check.Thank you.
/lgtm
Member
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Member
Author
No worries. It's super annoying work to go over all usages of all pointer status fields .. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Audited all fields after #12410
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Follow-up to #12410