[release-1.10] 🌱 Bump Go version to 1.24.9 by arshadd-b · Pull Request #12945 · kubernetes-sigs/cluster-api

arshadd-b · 2025-11-04T11:41:15Z

What this PR does / why we need it:
Bump Go version to 1.24.9
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Makefile

Tiltfile

wendy-ha18 · 2025-11-04T12:06:41Z

I'm not sure if should we also bump kubernetes_version to v1.34.0 for CAPI v1.10:
https://github.com/kubernetes-sigs/cluster-api/blob/release-1.10/Tiltfile#L5

Kubernetes v1.34 also supported Go v1.24.9: https://github.com/kubernetes/kubernetes/blob/release-1.34/.go-version

chrischdi · 2025-11-04T14:08:24Z

/retitle [release-1.10] 🌱 Bump Go version to 1.24.9

chrischdi · 2025-11-04T14:12:21Z

.github/workflows/pr-golangci-lint.yaml

        with:
-          version: v1.63.4
-          args: --out-format=colored-line-number
+          version: v2.4.0


Maybe we can get around bumping to v2 via using v1.64.0 here.

Bumping to v2 involves way more than we probably want on this PR.

yes checked it many changes are there if we move to v2
will try upgrading to v1.64.0

I think after upgrading it to 1.64.2 , have some errors , will fix those

There are some issues with 1.64.2 in ginkgolinter
I see in 1.64.3 it is fixed https://golangci-lint.run/product/changelog/#1646

chrischdi · 2025-11-04T14:13:07Z

We have to adapt #6356

I'm not sure if should we also bump kubernetes_version to v1.34.0 for CAPI v1.10: release-1.10/Tiltfile#L5

Kubernetes v1.34 also supported Go v1.24.9: kubernetes/kubernetes@release-1.34/.go-version

This is for release-1.10, so no we should not bump any kubernetes versions.

wendy-ha18 · 2025-11-04T23:59:54Z

another minor note but should we also update golangci-lint v1.64.2 in this file as well? (for CAPI release v1.10)

cluster-api/hack/tools/.custom-gcl.yaml

Lines 1 to 2 in eb0b49e

    
           version:  v1.63.4 
        
           name: golangci-lint-kal-v1.63.4

hack/tools/.custom-gcl.yaml

mboersma · 2025-11-06T16:22:18Z

Go v1.24.10 is out now, just FYI. See also #12962, which we can cherry-pick if you don't want to update this PR.

chrischdi

/lgtm

k8s-ci-robot · 2025-11-06T16:52:35Z

LGTM label has been added.

Details

Git tree hash: bc6c2d189606e1b3c0a6cd2dcad62cf6938c50aa

sbueringer · 2025-11-07T06:22:39Z

Thx everyone. Let's backport 1.24.10 on top

/lgtm
/approve

k8s-ci-robot · 2025-11-07T06:22:47Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [sbueringer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

sbueringer · 2025-11-07T06:23:05Z

/cherry-pick release-1.9

k8s-infra-cherrypick-robot · 2025-11-07T06:23:08Z

@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.9 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

sbueringer · 2025-11-07T06:23:31Z

/area dependency

k8s-infra-cherrypick-robot · 2025-11-07T06:25:29Z

@sbueringer: #12945 failed to apply on top of branch "release-1.9":

Applying: Bump GoVersion to 1.24.9
Using index info to reconstruct a base tree...
M	Makefile
M	Tiltfile
M	go.mod
M	netlify.toml
Falling back to patching base and 3-way merge...
Auto-merging netlify.toml
Auto-merging go.mod
Auto-merging Tiltfile
Auto-merging Makefile
CONFLICT (content): Merge conflict in Makefile
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Bump GoVersion to 1.24.9

Details

In response to this:

/cherry-pick release-1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

sbueringer · 2025-11-07T06:26:58Z

Can you try to open the same PR for 1.9?
If it turns out to be too much work let's not do it though.
There are no further releases for 1.9 planned would be just nice to get the cve scan green

arshadd-b · 2025-11-07T06:39:16Z

Can you try to open the same PR for 1.9? If it turns out to be too much work let's not do it though. There are no further releases for 1.9 planned would be just nice to get the cve scan green

sure will open a PR and see

chrischdi · 2025-11-07T08:35:13Z

go.mod


 go 1.23.0

+godebug default=go1.23


Just noticed, we have more than this go.mod. This change should be in all go.mod files 🤔

Yup let's follow-up for that

Bump GoVersion to 1.24.9

fc79c8e

k8s-ci-robot added this to the v1.10 milestone Nov 4, 2025

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 4, 2025

k8s-ci-robot requested review from chrischdi and jackfrancis November 4, 2025 11:41

k8s-ci-robot added do-not-merge/needs-area PR is missing an area label size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 4, 2025

wendy-ha18 reviewed Nov 4, 2025

View reviewed changes

Makefile Show resolved Hide resolved

Tiltfile Outdated Show resolved Hide resolved

arshadd-b force-pushed the Bump-Go-Version branch from 52a2516 to f90da19 Compare November 4, 2025 12:03

arshadd-b force-pushed the Bump-Go-Version branch 2 times, most recently from 703380c to 6b54787 Compare November 4, 2025 12:09

k8s-ci-robot changed the title ~~🌱 Bump GoVersion to 1.24.9~~ [release-1.10] 🌱 Bump Go version to 1.24.9 Nov 4, 2025

chrischdi reviewed Nov 4, 2025

View reviewed changes

arshadd-b force-pushed the Bump-Go-Version branch 2 times, most recently from 50ca7bf to 7b7ff11 Compare November 4, 2025 16:15

update golangci-lint version

410efc9

arshadd-b force-pushed the Bump-Go-Version branch from 7b7ff11 to 410efc9 Compare November 4, 2025 16:25

arshadd-b force-pushed the Bump-Go-Version branch 5 times, most recently from a36c56a to 581e449 Compare November 5, 2025 13:51

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 5, 2025

chrischdi reviewed Nov 5, 2025

View reviewed changes

hack/tools/.custom-gcl.yaml Outdated Show resolved Hide resolved

fix lint issues

7877a10

arshadd-b force-pushed the Bump-Go-Version branch from 581e449 to 7877a10 Compare November 6, 2025 03:57

chrischdi reviewed Nov 6, 2025

View reviewed changes

k8s-ci-robot assigned chrischdi Nov 6, 2025

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 6, 2025

sbueringer added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Nov 7, 2025

k8s-ci-robot assigned sbueringer Nov 7, 2025

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 7, 2025

k8s-ci-robot added area/dependency Issues or PRs related to dependency changes and removed do-not-merge/needs-area PR is missing an area label labels Nov 7, 2025

k8s-ci-robot merged commit 941e4e2 into kubernetes-sigs:release-1.10 Nov 7, 2025
20 checks passed

chrischdi reviewed Nov 7, 2025

View reviewed changes

chrischdi mentioned this pull request Nov 7, 2025

[release-1.10] 🌱 Go Bump 1.24 follow-up: also set godebug on modules #12967

Merged

Conversation

arshadd-b commented Nov 4, 2025

Uh oh!

Uh oh!

Uh oh!

wendy-ha18 commented Nov 4, 2025

Uh oh!

chrischdi commented Nov 4, 2025

Uh oh!

chrischdi Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

arshadd-b Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

arshadd-b Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

arshadd-b Nov 5, 2025

Choose a reason for hiding this comment

Uh oh!

chrischdi commented Nov 4, 2025

Uh oh!

wendy-ha18 commented Nov 4, 2025

Uh oh!

Uh oh!

mboersma commented Nov 6, 2025

Uh oh!

chrischdi left a comment

Choose a reason for hiding this comment

Uh oh!

k8s-ci-robot commented Nov 6, 2025

Uh oh!

sbueringer commented Nov 7, 2025

Uh oh!

k8s-ci-robot commented Nov 7, 2025

Uh oh!

sbueringer commented Nov 7, 2025

Uh oh!

k8s-infra-cherrypick-robot commented Nov 7, 2025

Uh oh!

sbueringer commented Nov 7, 2025

Uh oh!

Uh oh!

k8s-infra-cherrypick-robot commented Nov 7, 2025

Uh oh!

sbueringer commented Nov 7, 2025

Uh oh!

arshadd-b commented Nov 7, 2025

Uh oh!

chrischdi Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

sbueringer Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants