[release-1.11] 🌱 Makefile: ensure KAL is compiled using golangci-lint v2.7.0#13107
Conversation
feef7a7 to
055bfcf
Compare
|
|
|
@chrischdi: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/easycla |
055bfcf to
061947f
Compare
|
/cherry-pick release-1.11 |
|
@chrischdi: I cannot cherry-pick the present PR on top of its base branch ( DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/lgtm |
|
LGTM label has been added. DetailsGit tree hash: 5d38be2be9992e5bc657636837e3e2f652c4a2e2 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick release-1.10 |
|
@fabriziopandini: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@chrischdi: base branch (release-1.11) needs to differ from target branch (release-1.11) DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@fabriziopandini: #13107 failed to apply on top of branch "release-1.10": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it:
Github actions had been updated to a newer git cli version.
This broke golangcli-lint when building custom plugins like KAL:
v2.7.0 fixed this.
This PR ensures we use the correct version for building KAL, while not bumping golangci-lint used for other linting to control when we do the upgrade and have this as backportable PR.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
/area ci