Bug in manager_test

[mengqiy]

/kind bug

controller-runtime/pkg/manager/manager_test.go

Lines 254 to 286 in d6324a4

	It("should return an error if any Components fail to Start", func(done Done) {
	m, err := New(cfg, options)
	Expect(err).NotTo(HaveOccurred())
	c1 := make(chan struct{})
	Expect(m.Add(RunnableFunc(func(s <-chan struct{}) error {
	defer GinkgoRecover()
	defer close(c1)
	return nil
	}))).To(Succeed())
	c2 := make(chan struct{})
	Expect(m.Add(RunnableFunc(func(s <-chan struct{}) error {
	defer GinkgoRecover()
	defer close(c2)
	return fmt.Errorf("expected error")
	}))).To(Succeed())
	c3 := make(chan struct{})
	Expect(m.Add(RunnableFunc(func(s <-chan struct{}) error {
	defer GinkgoRecover()
	defer close(c3)
	return nil
	}))).To(Succeed())
	go func() {
	defer GinkgoRecover()
	Expect(m.Start(stop)).NotTo(HaveOccurred())
	close(done)
	}()
	<-c1
	<-c2
	<-c3
	})

This piece of code should expect an error in the end but actually it's not.

This test case should not panic, it should not use GinkgoRecover.

Probably there is a bug in the test.

[mengqiy]

cc: @droot @DirectXMan12

[DirectXMan12]

You almost always want to use GinkgoRecover when spawing goroutines (which a runnable is), and just about anything can panic (yay side effects not captured by the type system). In this case, for instance, if that channel is somehow nil, the test could panic.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[vincepri]

Closing in favor of #764

/close

[k8s-ci-robot]

@vincepri: Closing this issue.

In response to this:

Closing in favor of #764

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.