expose newResourceLock in manager.Options so that controllers can use customized resourceLock

[jzhoucliqr]

I have a use case to run a standalone aggregation-apiserver without native kube-apiserver. To enable leader selection for controllers, currently controller-runtime hardcode to use configmapLocks, which won't work for this case because configmap resource is not available in the aggregation-apiserver.

If we expose newResourceLock outside of manager.Options, then controllers can their own customized resourcelocks, and leader selection can work without native kube-apiserver.

This is a minor change, but will be very beneficial for standalone apiservers/controllers.

What do you guys think? I can have a PR if we agree this is a valid use case.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[jzhoucliqr]

/close

[k8s-ci-robot]

@jzhoucliqr: Closing this issue.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.