DeleteCollection does not work with Limit and Continue list options

[rajathagasthya]

PR #341 is trying to add Limit and Continue list options for paging. But there's no way to make it work with DeleteCollection because there is no way to grab the continue token returned by the server to delete the next page of things.

[DirectXMan12]

/kind bug

we need to fix this before the v0.2.0 release

[DirectXMan12]

The fix to this is fairly straightfoward -- accept a list object instead of a single object in DeleteAllOf, and populate it with the results.

[DirectXMan12]

/good-first-issue

[k8s-ci-robot]

@DirectXMan12:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

Details

In response to this:

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[DirectXMan12]

See also kubernetes/kubernetes#80877

[DirectXMan12]

might have to wait for an update on that ^

[adohe-zz]

sure, I will take this.

[DirectXMan12]

(note that there's some discussion on the above issue, so be aware. We might want to switch anyway, though, since getting back the list of deleted objects could be nice).

[serbrech]

we need to fix this before the v0.2.0 release

@DirectXMan12 DeleteAllOf is not in the 0.2.0-beta4 release, is it supposed to be in the final 0.2.0 release?

controller-runtime/pkg/client/interfaces.go

Line 65 in aaddbd9

type Writer interface {

[DirectXMan12]

It's in master now. It'll be in the final release.

[DirectXMan12]

upstream consensus seems to be that supporting this is a mistake. Plus, we can add support for passing list objects in the future w/o making breaking changes, so we can drop this for now

[rajathagasthya]

@DirectXMan12 So what needs to be dropped here? Not adding Limit and Continue support means pagination is not supported for list. But DeleteCollection doesn't permit adding that. In other words, how can we add limit and continue without affecting DeleteCollection?