-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Test that we don't leak goroutines on start and stop #724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@DirectXMan12: Please ensure the request meets the requirements listed here. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Any ideas on how to filter only the goroutines from manager/controller? Using the NumGoroutines directly in the test case returns all (including from test suite, its around ~43), do makes sense to iterate on this list and extract by file path maybe? |
Maybe by counting them before starting & stopping the manager or a controller, then checking if the count is back at where it was initially? |
Is there anything else to be done here? The PR is merged so I believe the issue can be closed. |
Closing given that #738 has been merged /close |
@vincepri: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
We should have tests for simple operations that make sure they don't leak goroutines. Namely,
manager.Start & stop
andcontroller.New
, both of which leaked in the past.We can use the runtime package to get the goroutine count.
/good-first-issue
The text was updated successfully, but these errors were encountered: