🐛 pkg/webhook/admission: set GVK on AdmissionReview responses #1293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/bug
k8s-ci-robot
added
the
size/L
|
/cc @vincepri |
k8s-ci-robot
added
the
lgtm
|
/milestone v0.7.x |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: estroz, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifying multiple
admissionReviewVersionsin a webhook config withv1as the first version causes untyped (no GVK)AdmissionReviewresponses to fail with an error likeThis error results from the API server checking response type for v1 but not v1beta1. By setting the
AdmissionReviewobject's GVK to the request's type if it exists or defaulting to v1, the webhook handler can patch over this problem./kind bug