⚠ Remove DelegatedClient, move Options in client.New #2150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
vincepri
force-pushed
the
remove-split
branch
from
7557702 to
74f39e2
Compare
|
/retest flake |
|
/retest |
1 similar comment
|
/retest |
FillZpp
reviewed
Jan 30, 2023
vincepri
force-pushed
the
remove-split
branch
from
74f39e2 to
c0d410a
Compare
|
/assign @sbueringer @FillZpp @alvaroaleman |
Signed-off-by: Vince Prignano <[email protected]>
vincepri
force-pushed
the
remove-split
branch
from
c0d410a to
d2c3550
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
irbekrm
added a commit
to irbekrm/istio-csr
that referenced
this pull request
May 24, 2023
Following c/r change in kubernetes-sigs/controller-runtime#2150 Signed-off-by: irbekrm <[email protected]>
17 tasks
irbekrm
added a commit
to irbekrm/istio-csr
that referenced
this pull request
May 26, 2023
…client Following c/r change in kubernetes-sigs/controller-runtime#2150 Signed-off-by: irbekrm <[email protected]>
aleskandro
added a commit
to aleskandro/machine-api-provider-aws
that referenced
this pull request
Jun 1, 2023
… namespace kubernetes-sigs/controller-runtime#2150 deprecated the DelegatedClient and added the CacheOption to the client.Options struct. This commit sync the newConfigManagedClient method with that deprecation.
aleskandro
added a commit
to aleskandro/machine-api-provider-aws
that referenced
this pull request
Jun 1, 2023
… namespace kubernetes-sigs/controller-runtime#2150 deprecated the DelegatedClient and added the CacheOption to the client.Options struct. This commit sync the newConfigManagedClient method with that deprecation.
ary1992
added a commit
to ary1992/gardener
that referenced
this pull request
Jun 28, 2023
10 tasks
yitsushi
added a commit
to weaveworks/weave-gitops
that referenced
this pull request
Oct 27, 2023
With the update, some other calls had to be updated: - `NewDiscoveryRESTMapper` expects an extra `HTTPClient` argument - `client` does not have `NewDelegatingClient` anymore, instead we can create the same resource with `client.New(...)` Resolves #3812 References: - #3812 - kubernetes-sigs/controller-runtime#2150 - https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.15.0 Signed-off-by: Balazs Nadasdi <[email protected]>
AsmaaNabilBakr
pushed a commit
to weaveworks/weave-gitops
that referenced
this pull request
Nov 6, 2023
With the update, some other calls had to be updated: - `NewDiscoveryRESTMapper` expects an extra `HTTPClient` argument - `client` does not have `NewDelegatingClient` anymore, instead we can create the same resource with `client.New(...)` Resolves #3812 References: - #3812 - kubernetes-sigs/controller-runtime#2150 - https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.15.0 Signed-off-by: Balazs Nadasdi <[email protected]>
AsmaaNabilBakr
added a commit
to weaveworks/weave-gitops
that referenced
this pull request
Nov 7, 2023
* fix duplicate icons * policy icon size * fix audit icon size * update icon * refactor: refactor away from deprecated wait.Poll calls With the update, some other calls had to be updated: - `NewDiscoveryRESTMapper` expects an extra `HTTPClient` argument - `client` does not have `NewDelegatingClient` anymore, instead we can create the same resource with `client.New(...)` Resolves #3812 References: - #3812 - kubernetes-sigs/controller-runtime#2150 - https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.15.0 Signed-off-by: Balazs Nadasdi <[email protected]> * try to update github.com/fluxcd/pkg/runtime to the earliest version with updated controller-runtime Signed-off-by: Balazs Nadasdi <[email protected]> * Cleanup datatable (#4091) * cleanup datatable * sort filtered items by `sortValue || value` * Update pkg/run/session/connect/connect.go Co-authored-by: Yiannis Triantafyllopoulos <[email protected]> * Refactoring Status column (#4098) * fix: Remove GitOps Run CLI commands * Replace the Sync/Suspend/Resume controls, used in the `SyncActions` and `CheckboxActions` components, with the new Sync/Suspend/Resume controls (the `SyncControl` component) (#4080) * Create the new `SyncControls` component for Sync/Suspend/Resume controls. * Move all components, related to syncing and suspending objects (existing `SyncActions` and `CheckboxActions` and new `SyncControls` and `ResumeIcon`), to the `Sync` folder. * Update the related UI snapshot. * Add `SyncControls` to exports. * Move custom actions to the start (left) of `SyncControls` buttons. * Re-arrange icons in `IconType` alphabetically. * add new svg icon as CLusterDiscovery icon * fix typo * update import order * build(deps): Bump google.golang.org/grpc from 1.51.0 to 1.56.3 Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.51.0 to 1.56.3. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.51.0...v1.56.3) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> * build(deps): Bump github.com/weaveworks/tf-controller/api version * build(deps): Bump postcss from 8.4.21 to 8.4.31 in /website Bumps [postcss](https://github.com/postcss/postcss) from 8.4.21 to 8.4.31. - [Release notes](https://github.com/postcss/postcss/releases) - [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md) - [Commits](postcss/postcss@8.4.21...8.4.31) --- updated-dependencies: - dependency-name: postcss dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> * chore: Remove GitOps Run components * build(deps): Remove gitops bucket server from build * chore: Remove unused code previously used for GitOps Run * build(deps): Bump @babel/traverse from 7.20.13 to 7.23.2 in /website Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.20.13 to 7.23.2. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.23.2/packages/babel-traverse) --- updated-dependencies: - dependency-name: "@babel/traverse" dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> * fix duplicate icons * remove extra space --------- Signed-off-by: Balazs Nadasdi <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Joshua Israel <[email protected]> Co-authored-by: Balazs Nadasdi <[email protected]> Co-authored-by: a.shabaan <[email protected]> Co-authored-by: Yiannis Triantafyllopoulos <[email protected]> Co-authored-by: Luiz Filho <[email protected]> Co-authored-by: yiannis <[email protected]> Co-authored-by: opudrovs <[email protected]> Co-authored-by: ahussein3 <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vince Prignano [email protected]