🌱 [0.14] Deprecate component configuration package #2165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This provides an early warning for users on 0.14 that the pkg/config types are going to be removed in a future release and they should migrate off. Signed-off-by: Vince Prignano <[email protected]>
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
|
/lgtm nit: I wonder if we should go with the standard cherry-pick bot PR titles: |
k8s-ci-robot
added
the
lgtm
renovate bot
referenced
this pull request
in open-feature/flagd
Feb 5, 2023
) [](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [sigs.k8s.io/controller-runtime](https://togithub.com/kubernetes-sigs/controller-runtime) | require | patch | `v0.14.2` -> `v0.14.3` | --- ### ⚠ Dependency Lookup Warnings ⚠ Warnings were logged while processing this repo. Please check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>kubernetes-sigs/controller-runtime</summary> ### [`v0.14.3`](https://togithub.com/kubernetes-sigs/controller-runtime/releases/tag/v0.14.3) [Compare Source](https://togithub.com/kubernetes-sigs/controller-runtime/compare/v0.14.2...v0.14.3) #### What's Changed - ✨ Add additional SubResource\* functions for FieldOwner by [@​k8s-infra-cherrypick-robot](https://togithub.com/k8s-infra-cherrypick-robot) in [https://github.com/kubernetes-sigs/controller-runtime/pull/2153](https://togithub.com/kubernetes-sigs/controller-runtime/pull/2153) - 🐛 Update golanci-lint script by [@​k8s-infra-cherrypick-robot](https://togithub.com/k8s-infra-cherrypick-robot) in [https://github.com/kubernetes-sigs/controller-runtime/pull/2152](https://togithub.com/kubernetes-sigs/controller-runtime/pull/2152) - 🌱 Bump kubebuilder-release-tools to v0.3.0 by [@​k8s-infra-cherrypick-robot](https://togithub.com/k8s-infra-cherrypick-robot) in [https://github.com/kubernetes-sigs/controller-runtime/pull/2154](https://togithub.com/kubernetes-sigs/controller-runtime/pull/2154) - 🌱 \[0.14] Deprecate component configuration package by [@​vincepri](https://togithub.com/vincepri) in [https://github.com/kubernetes-sigs/controller-runtime/pull/2165](https://togithub.com/kubernetes-sigs/controller-runtime/pull/2165) **Full Changelog**: kubernetes-sigs/controller-runtime@v0.14.2...v0.14.3 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/open-feature/flagd). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xMjQuMSIsInVwZGF0ZWRJblZlciI6IjM0LjEyNC4xIn0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
|
Hello! I am looking for more context or documentation about this change. Both examples in this repo are still using the deprecated methods. |
I am also wondering what the migration path looks like, since our static checker does not really like the deprecation warnings. |
|
@vincepri @sbueringer could you please help us here? |
|
Per commit message in 63e5fef:
What is missing is any info as to what package users should be looking to migrate to? |
|
👋 The codebase around configuration package is missing maintainers and the general integration between the configuration types and the manager options or controllers can be very confusing to use. There is currently no alternative implementation, folks could use their own json/yaml unmarshalling and configure manager options that way. Happy to revisit if we have folks stepping up to review, cleanup, support, and maintain the codebase. |
](https://renovatebot.com){kind=link}
vihangm
referenced
this pull request
in newrelic/newrelic-k8s-operator
May 15, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [sigs.k8s.io/controller-runtime](https://togithub.com/kubernetes-sigs/controller-runtime) | require | patch | `v0.14.1` -> `v0.14.6` | --- ### Release Notes <details> <summary>kubernetes-sigs/controller-runtime</summary> ### [`v0.14.6`](https://togithub.com/kubernetes-sigs/controller-runtime/releases/tag/v0.14.6) [Compare Source](https://togithub.com/kubernetes-sigs/controller-runtime/compare/v0.14.5...v0.14.6) #### What's Changed - 🐛 Preserve unstructured object GVKs when using \*ByObject cache options by [@​joelanford](https://togithub.com/joelanford) in [https://github.com/kubernetes-sigs/controller-runtime/pull/2249](https://togithub.com/kubernetes-sigs/controller-runtime/pull/2249) **Full Changelog**: kubernetes-sigs/controller-runtime@v0.14.5...v0.14.6 ### [`v0.14.5`](https://togithub.com/kubernetes-sigs/controller-runtime/releases/tag/v0.14.5) [Compare Source](https://togithub.com/kubernetes-sigs/controller-runtime/compare/v0.14.4...v0.14.5) #### What's Changed - 🐛 Allow to set GracefulShutdownTimeout to -1, disabling timeouts in [https://github.com/kubernetes-sigs/controller-runtime/pull/2198](https://togithub.com/kubernetes-sigs/controller-runtime/pull/2198) - 🌱 GVKForObject should handle multiple GVKs in Scheme gracefully in [https://github.com/kubernetes-sigs/controller-runtime/pull/2202](https://togithub.com/kubernetes-sigs/controller-runtime/pull/2202) - ✨ Add rest client request duration and size metrics in [https://github.com/kubernetes-sigs/controller-runtime/pull/2218](https://togithub.com/kubernetes-sigs/controller-runtime/pull/2218) - 🐛 Allow lazy restmapper to work with CRDs created at runtime in [https://github.com/kubernetes-sigs/controller-runtime/pull/2219](https://togithub.com/kubernetes-sigs/controller-runtime/pull/2219) **Full Changelog**: kubernetes-sigs/controller-runtime@v0.14.4...v0.14.5 ### [`v0.14.4`](https://togithub.com/kubernetes-sigs/controller-runtime/releases/tag/v0.14.4) [Compare Source](https://togithub.com/kubernetes-sigs/controller-runtime/compare/v0.14.3...v0.14.4) #### What's Changed - ✨ Provide a truly lazy restmapper by [@​k8s-infra-cherrypick-robot](https://togithub.com/k8s-infra-cherrypick-robot) in [https://github.com/kubernetes-sigs/controller-runtime/pull/2179](https://togithub.com/kubernetes-sigs/controller-runtime/pull/2179) **Full Changelog**: kubernetes-sigs/controller-runtime@v0.14.3...v0.14.4 ### [`v0.14.3`](https://togithub.com/kubernetes-sigs/controller-runtime/releases/tag/v0.14.3) [Compare Source](https://togithub.com/kubernetes-sigs/controller-runtime/compare/v0.14.2...v0.14.3) #### What's Changed - ✨ Add additional SubResource\* functions for FieldOwner by [@​k8s-infra-cherrypick-robot](https://togithub.com/k8s-infra-cherrypick-robot) in [https://github.com/kubernetes-sigs/controller-runtime/pull/2153](https://togithub.com/kubernetes-sigs/controller-runtime/pull/2153) - 🐛 Update golanci-lint script by [@​k8s-infra-cherrypick-robot](https://togithub.com/k8s-infra-cherrypick-robot) in [https://github.com/kubernetes-sigs/controller-runtime/pull/2152](https://togithub.com/kubernetes-sigs/controller-runtime/pull/2152) - 🌱 Bump kubebuilder-release-tools to v0.3.0 by [@​k8s-infra-cherrypick-robot](https://togithub.com/k8s-infra-cherrypick-robot) in [https://github.com/kubernetes-sigs/controller-runtime/pull/2154](https://togithub.com/kubernetes-sigs/controller-runtime/pull/2154) - 🌱 \[0.14] Deprecate component configuration package by [@​vincepri](https://togithub.com/vincepri) in [https://github.com/kubernetes-sigs/controller-runtime/pull/2165](https://togithub.com/kubernetes-sigs/controller-runtime/pull/2165) **Full Changelog**: kubernetes-sigs/controller-runtime@v0.14.2...v0.14.3 ### [`v0.14.2`](https://togithub.com/kubernetes-sigs/controller-runtime/releases/tag/v0.14.2) [Compare Source](https://togithub.com/kubernetes-sigs/controller-runtime/compare/v0.14.1...v0.14.2) #### What's Changed - \[release-0.14] 🌱 Bump k8s.io/\* to v0.26.1 by [@​sbueringer](https://togithub.com/sbueringer) in [https://github.com/kubernetes-sigs/controller-runtime/pull/2146](https://togithub.com/kubernetes-sigs/controller-runtime/pull/2146) **Full Changelog**: kubernetes-sigs/controller-runtime@v0.14.1...v0.14.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/newrelic/newrelic-k8s-operator). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS43OS4xIiwidXBkYXRlZEluVmVyIjoiMzUuNzkuMSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides an early warning for users on 0.14 that the pkg/config types are going to be removed in a future release and they should migrate off.
Signed-off-by: Vince Prignano [email protected]
/assign @sbueringer