🐛 Create BinaryAssetsDirectory if it doesn't exist #3137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stefan Büringer [email protected]
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
10 tasks
k8s-ci-robot
added
the
size/XS
|
/assign @alvaroaleman @vincepri /hold |
k8s-ci-robot
added
the
do-not-merge/hold
|
/lgtm Issue and fix seem to make sense to me |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: bf023d66e27fafe9cb32d8265aa4745cb88e082c
|
|
Adding an /hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/lgtm |
tomasaschan
added a commit
to tomasaschan/kro
that referenced
this pull request
Mar 13, 2025
This relies on yet unreleased features of controller-runtime, but it will we'll be able to roll forward to the next patch release as soon as one that contains both kubernetes-sigs/controller-runtime#3135 and kubernetes-sigs/controller-runtime#3137 is released.
tomasaschan
added a commit
to tomasaschan/kro
that referenced
this pull request
Mar 13, 2025
This relies on yet unreleased features of controller-runtime, but it will we'll be able to roll forward to the next patch release as soon as one that contains both kubernetes-sigs/controller-runtime#3135 and kubernetes-sigs/controller-runtime#3137 is released.
tomasaschan
added a commit
to tomasaschan/kro
that referenced
this pull request
Mar 14, 2025
This relies on yet unreleased features of controller-runtime, but it will we'll be able to roll forward to the next patch release as soon as one that contains both kubernetes-sigs/controller-runtime#3135 and kubernetes-sigs/controller-runtime#3137 is released.
tomasaschan
added a commit
to tomasaschan/kro
that referenced
this pull request
Mar 14, 2025
This relies on yet unreleased features of controller-runtime, but it will we'll be able to roll forward to the next patch release as soon as one that contains both kubernetes-sigs/controller-runtime#3135 and kubernetes-sigs/controller-runtime#3137 is released.
tomasaschan
added a commit
to tomasaschan/kro
that referenced
this pull request
Mar 17, 2025
This relies on yet unreleased features of controller-runtime, but it will we'll be able to roll forward to the next patch release as soon as one that contains both kubernetes-sigs/controller-runtime#3135 and kubernetes-sigs/controller-runtime#3137 is released.
tomasaschan
added a commit
to tomasaschan/kro
that referenced
this pull request
Mar 19, 2025
This relies on yet unreleased features of controller-runtime, but it will we'll be able to roll forward to the next patch release as soon as one that contains both kubernetes-sigs/controller-runtime#3135 and kubernetes-sigs/controller-runtime#3137 is released.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stefan Büringer [email protected]
Fixes #2810 (comment)