[release-0.20] 🌱 Handlers: Default to LowPriorityWhenUnchanged without a wrapper #3179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e interface (kubernetes-sigs#3111) * implement priority queue for handlers Signed-off-by: Troy Connor <[email protected]> * check object before placing in priorityqueue Signed-off-by: Troy Connor <[email protected]> * implement priority queue Signed-off-by: Troy Connor <[email protected]> --------- Signed-off-by: Troy Connor <[email protected]>
This change makes the `TypedFuncs` and `enqueueRequestsFromMapFunc` set a low priority when the object is unchanged by default, as well as extend the test coverage to validate this behavior for `EnqueueRequestForOwner`.
Addresses Stefans comments
The handlers themselves already support this, so there is no need to also do it in the builder.
Signed-off-by: Stefan Büringer [email protected]
We already did this for RequestForOwner, but not the typed variation, this change adds that.
k8s-ci-robot
added
approved
sbueringer
added
the
do-not-merge/hold
sbueringer
reviewed
Mar 24, 2025
| e.mapAndEnqueue(ctx, q, evt.Object, reqs) | ||
|
|
||
| var lowPriority bool | ||
| if e.objectImplementsClientObject && isPriorityQueue(q) && !isNil(evt.Object) { |
There was a problem hiding this comment.
I would suggest to also cherry-pick: #3162
There was a problem hiding this comment.
I'll take that back. That would introduce too many changes
|
Thank you! /lgtm |
k8s-ci-robot
added
lgtm
|
LGTM label has been added. Git tree hash: 9158825b3f0e9ff576c6a1c57232a98bd033c60c
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cherry-picks all the changes related to #3105 onto release-0.20
/assign @sbueringer