Skip to content

✨ Add a metrics to expose informer cache's length #3189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

halfcrazy
Copy link
Contributor

Fix #3182

metrics explain

# HELP controller_runtime_cache_resources Number of resources cached in the controller-runtime local cache, broken down by group, version, kind
# TYPE controller_runtime_cache_resources gauge
controller_runtime_cache_resources{group="webapp.my.domain",kind="Guestbook",version="v1"} 1

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 4, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: halfcrazy
Once this PR has been reviewed and has the lgtm label, please assign vincepri for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 4, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @halfcrazy. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 4, 2025
metrics explain
controller_runtime_cache_resources{group="webapp.my.domain",kind="Guestbook",version="v1"} 1

Signed-off-by: Yan Zhu <[email protected]>
@xigang
Copy link

xigang commented Apr 7, 2025

@halfcrazy Informer metrics have already been implemented in the Kubernetes repo and will be synced to client-go. There's no need to implement them within controller-runtime.

xref: kubernetes/kubernetes#129160

@sbueringer
Copy link
Member

@xigang thx for chiming in!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a new metrics to expose local cached items size
4 participants