Validate groups list.

[guettli]

I had accidentally added the version to the group: groups=example.com/v1beta1

Broken:

//+kubebuilder:webhook:path=/validate-example-com-v1beta1-foo,mutating=false,failurePolicy=fail,sideEffects=None,groups=example.com/v1beta1,resources=foos,verbs=create;update,versions=v1beta1,name=validation.example.syself.com,admissionReviewVersions={v1,v1beta1}

After removing "v1beta1" it worked.

Good:

//+kubebuilder:webhook:path=/validate-example-com-v1beta1-foo,mutating=false,failurePolicy=fail,sideEffects=None,groups=example.com,resources=foos,verbs=create;update,versions=v1beta1,name=validation.example.syself.com,admissionReviewVersions={v1,v1beta1}

It would be nice if the controller-tools would detect that.

[JoelSpeed]

I believe controller-gen should be able to verify this string while generating the webhook manifests, and ensure that the group is actually a group, and not a group version.

This feels to me like a valuable validation to add, to help our users out

[sbueringer]

Seems reasonable. Feel free to open a PR. Could be probably done roughly in this area of the code: #1128

[guettli]

I created #1144

[sbueringer]

/close

xref #1144 (comment)

[k8s-ci-robot]

@sbueringer: Closing this issue.

In response to this:

/close

xref #1144 (comment)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.