Skip to content

⚠️Bump to k8s.io/* v0.33.0-alpha.2 #1153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 28, 2025

Conversation

dongjiang1989
Copy link
Contributor

  1. Bump to k8s.io/* v0.33.0-alpha.2
  2. Release envtest to v0.33.0-alpha.2

Signed-off-by: dongjiang <[email protected]>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 28, 2025
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 28, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @dongjiang1989. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 28, 2025
@dongjiang1989
Copy link
Contributor Author

Maybe some warning

 $ setup-envtest use --use-env -p path v1.33.0-alpha.2    
version be a valid version, or simply 'latest' or 'latest-on-disk': unable to parse "v1.33.0-alpha.2" as a version stringshould be X.Y.Z, where Z may be '*','x', or left off entirely to denote a wildcard, optionally prefixed by ~|<|<=, and optionallyfollowed by ! (latest remote version)

@sbueringer
Copy link
Member

Maybe some warning

 $ setup-envtest use --use-env -p path v1.33.0-alpha.2    
version be a valid version, or simply 'latest' or 'latest-on-disk': unable to parse "v1.33.0-alpha.2" as a version stringshould be X.Y.Z, where Z may be '*','x', or left off entirely to denote a wildcard, optionally prefixed by ~|<|<=, and optionallyfollowed by ! (latest remote version)

Let's have a separate PR for the envtest release please.

We can publish alpha / beta / RC binaries, but setup-envtest does not support downloading them (still possible to use them via some simple wget | tar or so)

In general I'm not sure if we want to have envtest binary releases for every alpha / beta / RC release. But no strong opinion from my side

@sbueringer
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 28, 2025
@dongjiang1989
Copy link
Contributor Author

Let's have a separate PR for the envtest release please.

Thanks @sbueringer
I got it
Remove envtest yaml to next PR

@dongjiang1989 dongjiang1989 changed the title ⚠️Bump to k8s.io/* v0.33.0-alpha.2 and release envtest to v0.33.0-alpha.2 ⚠️Bump to k8s.io/* v0.33.0-alpha.2 Feb 28, 2025
@sbueringer sbueringer added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Feb 28, 2025
@sbueringer
Copy link
Member

Thx!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 28, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 10e3e626eedfa3347e2a8f0bb4091bb7ccde560f

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dongjiang1989, sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 28, 2025
@k8s-ci-robot k8s-ci-robot merged commit c81b1d8 into kubernetes-sigs:main Feb 28, 2025
12 checks passed
@dongjiang1989 dongjiang1989 deleted the update-v0.33.0 branch February 28, 2025 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants