test(token reconciling): have tests initialize the prom client reconciling through the descheduler's bootstraping entry too by ingvagabund · Pull Request #1820 · kubernetes-sigs/descheduler

ingvagabund · 2026-02-04T11:33:05Z

Description

Have unit tests running prom client reconciling on the level of the reconciler also initialize the reconciler through constructing a full descheduler.

Checklist

Please ensure your pull request meets the following criteria before submitting
for review, these items will be used by reviewers to assess the quality and
completeness of your changes:

…eating a stop channel

…by two tabs

Copilot

Pull request overview

This PR refactors the Prometheus client controller tests to be context-driven and extends coverage so the same test cases run both against the controller directly and through the full descheduler wiring.

Changes:

Updated setupPromClientControllerTest to accept a context.Context and use ctx.Done() for informer lifecycle instead of a bespoke stopCh channel.
Adjusted TestPromClientControllerSync_InvalidConfig and TestPromClientControllerSync_EventHandler to create/cancel contexts explicitly and pass them into the shared test setup.
Refactored TestPromClientControllerSync_ClientCreation to run each test case in two modes (direct prom reconciler vs. full descheduler) while reusing the same assertions on client creation, token handling, and transport cleanup.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…ient tests build an entire descheduler as well

…and namespace from the implicitly generated secret object

… two tabs

…nt tests build an entire descheduler as well

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…ld an entire descheduler as well

k8s-ci-robot · 2026-02-04T12:43:27Z

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

… (#4098) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [kubernetes-sigs/descheduler](https://github.com/kubernetes-sigs/descheduler) | minor | `0.34.0` → `v0.35.0` | --- ### Release Notes <details> <summary>kubernetes-sigs/descheduler (kubernetes-sigs/descheduler)</summary> ### [`v0.35.0`](https://github.com/kubernetes-sigs/descheduler/releases/tag/v0.35.0): Descheduler v0.35.0 [Compare Source](kubernetes-sigs/descheduler@v0.34.0...v0.35.0) #### What's Changed - feat: enable pod protection based on storage classes by [@ricardomaraschini](https://github.com/ricardomaraschini) in [#1752](kubernetes-sigs/descheduler#1752) - fix: pod resource calculation to consider native sidecars by [@a7i](https://github.com/a7i) in [#1771](kubernetes-sigs/descheduler#1771) - docs: fix incorrect gracePeriodSeconds default in README.md by [@petersalas](https://github.com/petersalas) in [#1773](kubernetes-sigs/descheduler#1773) - docs: fix README.md link to kubernetes bot commands by [@Sycrosity](https://github.com/Sycrosity) in [#1772](kubernetes-sigs/descheduler#1772) - Fix "Current requires cgo or $USER set in environment" error by [@abelfodil](https://github.com/abelfodil) in [#1764](kubernetes-sigs/descheduler#1764) - refactor(TestPodLifeTime): remove ineffective owner references assignments by [@ingvagabund](https://github.com/ingvagabund) in [#1781](kubernetes-sigs/descheduler#1781) - refactor(TestPodLifeTime): have a pod fully created through BuildTestPod without any edits by [@ingvagabund](https://github.com/ingvagabund) in [#1782](kubernetes-sigs/descheduler#1782) - refactor(TestPodLifeTime): consolidations, simplifications and node instance for each unit test by [@ingvagabund](https://github.com/ingvagabund) in [#1783](kubernetes-sigs/descheduler#1783) - refactor(TestPodLifeTime): inline pod creation in each unit test to avoid accidental pod spec updates by [@ingvagabund](https://github.com/ingvagabund) in [#1784](kubernetes-sigs/descheduler#1784) - refactor(TestPodLifeTime): update unit test names and simplify pod creation by [@ingvagabund](https://github.com/ingvagabund) in [#1785](kubernetes-sigs/descheduler#1785) - feat(TestPodLifeTime): check only expected pods are evicted by [@ingvagabund](https://github.com/ingvagabund) in [#1787](kubernetes-sigs/descheduler#1787) - feat(PodLifeTime): document the plugin with details that can be used for reasoning during reviews and design discussions by [@ingvagabund](https://github.com/ingvagabund) in [#1789](kubernetes-sigs/descheduler#1789) - refactor(TestPodLifeTime): split the unit tests into smaller semantically close groups by [@ingvagabund](https://github.com/ingvagabund) in [#1790](kubernetes-sigs/descheduler#1790) - refactor(TestFindDuplicatePods): have a pod fully created through BuildTestPod without any edits by [@ingvagabund](https://github.com/ingvagabund) in [#1791](kubernetes-sigs/descheduler#1791) - refactor(TestFindDuplicatePods): reduce duplicates and inline by [@ingvagabund](https://github.com/ingvagabund) in [#1792](kubernetes-sigs/descheduler#1792) - refactor(TestRemoveDuplicates): reduce test code duplication by [@ingvagabund](https://github.com/ingvagabund) in [#1793](kubernetes-sigs/descheduler#1793) - refactor(TestRemovePodsHavingTooManyRestarts): inline object creation by [@ingvagabund](https://github.com/ingvagabund) in [#1794](kubernetes-sigs/descheduler#1794) - refactor(TestPodAntiAffinity): inline object creation by [@ingvagabund](https://github.com/ingvagabund) in [#1795](kubernetes-sigs/descheduler#1795) - refactor(TestRemovePodsViolatingNodeAffinity): inline object creation by [@ingvagabund](https://github.com/ingvagabund) in [#1796](kubernetes-sigs/descheduler#1796) - refactor(TestDeletePodsViolatingNodeTaints): inline object creation by [@ingvagabund](https://github.com/ingvagabund) in [#1797](kubernetes-sigs/descheduler#1797) - doc: introduce contributing guidelines specific to the project by [@ingvagabund](https://github.com/ingvagabund) in [#1798](kubernetes-sigs/descheduler#1798) - refactor(TestDefaultEvictor): de-dup code and use helpers by [@ingvagabund](https://github.com/ingvagabund) in [#1803](kubernetes-sigs/descheduler#1803) - refactor(plugins): simplify the way pods are created by [@ingvagabund](https://github.com/ingvagabund) in [#1804](kubernetes-sigs/descheduler#1804) - fix(TestReadyNodesWithNodeSelector): make sure nodeLister.List always returns a non-empty list so the lister is always tested by [@ingvagabund](https://github.com/ingvagabund) in [#1800](kubernetes-sigs/descheduler#1800) - refactor(pkg/framework/profile): dedup unit test code by [@ingvagabund](https://github.com/ingvagabund) in [#1806](kubernetes-sigs/descheduler#1806) - doc(Design Decisions FAQ): Why doesn't the framework provide helpers for registering and retrieving indexers for plugins by [@ingvagabund](https://github.com/ingvagabund) in [#1807](kubernetes-sigs/descheduler#1807) - feat(profile): inject a plugin instance ID to each built plugin by [@ingvagabund](https://github.com/ingvagabund) in [#1808](kubernetes-sigs/descheduler#1808) - feat: register a node indexer for the global node selector instead of listing nodes with the selector by [@ingvagabund](https://github.com/ingvagabund) in [#1802](kubernetes-sigs/descheduler#1802) - chore(pkg/descheduler): make TestPodEvictorReset table driven by [@ingvagabund](https://github.com/ingvagabund) in [#1810](kubernetes-sigs/descheduler#1810) - refactor(pkg/operator): replace informerResource with a kubeClientSandbox by [@ingvagabund](https://github.com/ingvagabund) in [#1811](kubernetes-sigs/descheduler#1811) - refactor(pkg/descheduler): more handlers and dropping unused code by [@ingvagabund](https://github.com/ingvagabund) in [#1813](kubernetes-sigs/descheduler#1813) - refactor(pkg/descheduler): create fake shared informer factory only once by [@ingvagabund](https://github.com/ingvagabund) in [#1812](kubernetes-sigs/descheduler#1812) - fix(kubeClientSandbox): do not wait for pods in the fake indexers if they are already deleted by [@ingvagabund](https://github.com/ingvagabund) in [#1814](kubernetes-sigs/descheduler#1814) - test(pkg/descheduler): test a prometheus client update propagates to a plugin profile handle by [@ingvagabund](https://github.com/ingvagabund) in [#1816](kubernetes-sigs/descheduler#1816) - Add namespace label selector by [@W1seKappa](https://github.com/W1seKappa) in [#1786](kubernetes-sigs/descheduler#1786) - tests: Prom client testing by [@ingvagabund](https://github.com/ingvagabund) in [#1818](kubernetes-sigs/descheduler#1818) - Deduplicate descheduler initialization code so unit tests test more of the production code by [@ingvagabund](https://github.com/ingvagabund) in [#1819](kubernetes-sigs/descheduler#1819) - test(token reconciling): have tests initialize the prom client reconciling through the descheduler's bootstraping entry too by [@ingvagabund](https://github.com/ingvagabund) in [#1820](kubernetes-sigs/descheduler#1820) - refactor(promClientController): split it into two prom client controllers by [@ingvagabund](https://github.com/ingvagabund) in [#1821](kubernetes-sigs/descheduler#1821) - feat(pkg/descheduler): create profiles outside the descheduling cycle by [@ingvagabund](https://github.com/ingvagabund) in [#1815](kubernetes-sigs/descheduler#1815) - refactor: move prometheus client controller related code under a seperate file by [@ingvagabund](https://github.com/ingvagabund) in [#1823](kubernetes-sigs/descheduler#1823) - Update go dependecies to fix vulnerabilities by [@sammedsingalkar09](https://github.com/sammedsingalkar09) in [#1822](kubernetes-sigs/descheduler#1822) - chore: extend the list of supported Go versions by [@ingvagabund](https://github.com/ingvagabund) in [#1828](kubernetes-sigs/descheduler#1828) - bump(golangci-lint): update and migrate by [@ingvagabund](https://github.com/ingvagabund) in [#1829](kubernetes-sigs/descheduler#1829) - \[v0.35.0] bump to kubernetes 1.35 deps by [@a7i](https://github.com/a7i) in [#1827](kubernetes-sigs/descheduler#1827) - chore: upgrade github.com/gomarkdown/markdown to latest version by [@a7i](https://github.com/a7i) in [#1831](kubernetes-sigs/descheduler#1831) - \[v0.35.0] update docs and manifests by [@a7i](https://github.com/a7i) in [#1832](kubernetes-sigs/descheduler#1832) - Change annotations condition to deploymentAnnotations for Deployment object annotations by [@davidandreoletti](https://github.com/davidandreoletti) in [#1830](kubernetes-sigs/descheduler#1830) #### New Contributors - [@petersalas](https://github.com/petersalas) made their first contribution in [#1773](kubernetes-sigs/descheduler#1773) - [@Sycrosity](https://github.com/Sycrosity) made their first contribution in [#1772](kubernetes-sigs/descheduler#1772) - [@abelfodil](https://github.com/abelfodil) made their first contribution in [#1764](kubernetes-sigs/descheduler#1764) - [@W1seKappa](https://github.com/W1seKappa) made their first contribution in [#1786](kubernetes-sigs/descheduler#1786) - [@sammedsingalkar09](https://github.com/sammedsingalkar09) made their first contribution in [#1822](kubernetes-sigs/descheduler#1822) - [@davidandreoletti](https://github.com/davidandreoletti) made their first contribution in [#1830](kubernetes-sigs/descheduler#1830) **Full Changelog**: <kubernetes-sigs/descheduler@v0.34.0...v0.35.0> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://gitea.alexlebens.dev/alexlebens/infrastructure/pulls/4098 Co-authored-by: Renovate Bot <renovate-bot@alexlebens.net> Co-committed-by: Renovate Bot <renovate-bot@alexlebens.net>

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [descheduler](https://github.com/kubernetes-sigs/descheduler) | minor | `0.34.0` → `0.35.0` | --- ### Release Notes <details> <summary>kubernetes-sigs/descheduler (descheduler)</summary> ### [`v0.35.0`](https://github.com/kubernetes-sigs/descheduler/releases/tag/v0.35.0): Descheduler v0.35.0 [Compare Source](kubernetes-sigs/descheduler@v0.34.0...v0.35.0) ##### What's Changed - feat: enable pod protection based on storage classes by [@ricardomaraschini](https://github.com/ricardomaraschini) in [#1752](kubernetes-sigs/descheduler#1752) - fix: pod resource calculation to consider native sidecars by [@a7i](https://github.com/a7i) in [#1771](kubernetes-sigs/descheduler#1771) - docs: fix incorrect gracePeriodSeconds default in README.md by [@petersalas](https://github.com/petersalas) in [#1773](kubernetes-sigs/descheduler#1773) - docs: fix README.md link to kubernetes bot commands by [@Sycrosity](https://github.com/Sycrosity) in [#1772](kubernetes-sigs/descheduler#1772) - Fix "Current requires cgo or $USER set in environment" error by [@abelfodil](https://github.com/abelfodil) in [#1764](kubernetes-sigs/descheduler#1764) - refactor(TestPodLifeTime): remove ineffective owner references assignments by [@ingvagabund](https://github.com/ingvagabund) in [#1781](kubernetes-sigs/descheduler#1781) - refactor(TestPodLifeTime): have a pod fully created through BuildTestPod without any edits by [@ingvagabund](https://github.com/ingvagabund) in [#1782](kubernetes-sigs/descheduler#1782) - refactor(TestPodLifeTime): consolidations, simplifications and node instance for each unit test by [@ingvagabund](https://github.com/ingvagabund) in [#1783](kubernetes-sigs/descheduler#1783) - refactor(TestPodLifeTime): inline pod creation in each unit test to avoid accidental pod spec updates by [@ingvagabund](https://github.com/ingvagabund) in [#1784](kubernetes-sigs/descheduler#1784) - refactor(TestPodLifeTime): update unit test names and simplify pod creation by [@ingvagabund](https://github.com/ingvagabund) in [#1785](kubernetes-sigs/descheduler#1785) - feat(TestPodLifeTime): check only expected pods are evicted by [@ingvagabund](https://github.com/ingvagabund) in [#1787](kubernetes-sigs/descheduler#1787) - feat(PodLifeTime): document the plugin with details that can be used for reasoning during reviews and design discussions by [@ingvagabund](https://github.com/ingvagabund) in [#1789](kubernetes-sigs/descheduler#1789) - refactor(TestPodLifeTime): split the unit tests into smaller semantically close groups by [@ingvagabund](https://github.com/ingvagabund) in [#1790](kubernetes-sigs/descheduler#1790) - refactor(TestFindDuplicatePods): have a pod fully created through BuildTestPod without any edits by [@ingvagabund](https://github.com/ingvagabund) in [#1791](kubernetes-sigs/descheduler#1791) - refactor(TestFindDuplicatePods): reduce duplicates and inline by [@ingvagabund](https://github.com/ingvagabund) in [#1792](kubernetes-sigs/descheduler#1792) - refactor(TestRemoveDuplicates): reduce test code duplication by [@ingvagabund](https://github.com/ingvagabund) in [#1793](kubernetes-sigs/descheduler#1793) - refactor(TestRemovePodsHavingTooManyRestarts): inline object creation by [@ingvagabund](https://github.com/ingvagabund) in [#1794](kubernetes-sigs/descheduler#1794) - refactor(TestPodAntiAffinity): inline object creation by [@ingvagabund](https://github.com/ingvagabund) in [#1795](kubernetes-sigs/descheduler#1795) - refactor(TestRemovePodsViolatingNodeAffinity): inline object creation by [@ingvagabund](https://github.com/ingvagabund) in [#1796](kubernetes-sigs/descheduler#1796) - refactor(TestDeletePodsViolatingNodeTaints): inline object creation by [@ingvagabund](https://github.com/ingvagabund) in [#1797](kubernetes-sigs/descheduler#1797) - doc: introduce contributing guidelines specific to the project by [@ingvagabund](https://github.com/ingvagabund) in [#1798](kubernetes-sigs/descheduler#1798) - refactor(TestDefaultEvictor): de-dup code and use helpers by [@ingvagabund](https://github.com/ingvagabund) in [#1803](kubernetes-sigs/descheduler#1803) - refactor(plugins): simplify the way pods are created by [@ingvagabund](https://github.com/ingvagabund) in [#1804](kubernetes-sigs/descheduler#1804) - fix(TestReadyNodesWithNodeSelector): make sure nodeLister.List always returns a non-empty list so the lister is always tested by [@ingvagabund](https://github.com/ingvagabund) in [#1800](kubernetes-sigs/descheduler#1800) - refactor(pkg/framework/profile): dedup unit test code by [@ingvagabund](https://github.com/ingvagabund) in [#1806](kubernetes-sigs/descheduler#1806) - doc(Design Decisions FAQ): Why doesn't the framework provide helpers for registering and retrieving indexers for plugins by [@ingvagabund](https://github.com/ingvagabund) in [#1807](kubernetes-sigs/descheduler#1807) - feat(profile): inject a plugin instance ID to each built plugin by [@ingvagabund](https://github.com/ingvagabund) in [#1808](kubernetes-sigs/descheduler#1808) - feat: register a node indexer for the global node selector instead of listing nodes with the selector by [@ingvagabund](https://github.com/ingvagabund) in [#1802](kubernetes-sigs/descheduler#1802) - chore(pkg/descheduler): make TestPodEvictorReset table driven by [@ingvagabund](https://github.com/ingvagabund) in [#1810](kubernetes-sigs/descheduler#1810) - refactor(pkg/operator): replace informerResource with a kubeClientSandbox by [@ingvagabund](https://github.com/ingvagabund) in [#1811](kubernetes-sigs/descheduler#1811) - refactor(pkg/descheduler): more handlers and dropping unused code by [@ingvagabund](https://github.com/ingvagabund) in [#1813](kubernetes-sigs/descheduler#1813) - refactor(pkg/descheduler): create fake shared informer factory only once by [@ingvagabund](https://github.com/ingvagabund) in [#1812](kubernetes-sigs/descheduler#1812) - fix(kubeClientSandbox): do not wait for pods in the fake indexers if they are already deleted by [@ingvagabund](https://github.com/ingvagabund) in [#1814](kubernetes-sigs/descheduler#1814) - test(pkg/descheduler): test a prometheus client update propagates to a plugin profile handle by [@ingvagabund](https://github.com/ingvagabund) in [#1816](kubernetes-sigs/descheduler#1816) - Add namespace label selector by [@W1seKappa](https://github.com/W1seKappa) in [#1786](kubernetes-sigs/descheduler#1786) - tests: Prom client testing by [@ingvagabund](https://github.com/ingvagabund) in [#1818](kubernetes-sigs/descheduler#1818) - Deduplicate descheduler initialization code so unit tests test more of the production code by [@ingvagabund](https://github.com/ingvagabund) in [#1819](kubernetes-sigs/descheduler#1819) - test(token reconciling): have tests initialize the prom client reconciling through the descheduler's bootstraping entry too by [@ingvagabund](https://github.com/ingvagabund) in [#1820](kubernetes-sigs/descheduler#1820) - refactor(promClientController): split it into two prom client controllers by [@ingvagabund](https://github.com/ingvagabund) in [#1821](kubernetes-sigs/descheduler#1821) - feat(pkg/descheduler): create profiles outside the descheduling cycle by [@ingvagabund](https://github.com/ingvagabund) in [#1815](kubernetes-sigs/descheduler#1815) - refactor: move prometheus client controller related code under a seperate file by [@ingvagabund](https://github.com/ingvagabund) in [#1823](kubernetes-sigs/descheduler#1823) - Update go dependecies to fix vulnerabilities by [@sammedsingalkar09](https://github.com/sammedsingalkar09) in [#1822](kubernetes-sigs/descheduler#1822) - chore: extend the list of supported Go versions by [@ingvagabund](https://github.com/ingvagabund) in [#1828](kubernetes-sigs/descheduler#1828) - bump(golangci-lint): update and migrate by [@ingvagabund](https://github.com/ingvagabund) in [#1829](kubernetes-sigs/descheduler#1829) - \[v0.35.0] bump to kubernetes 1.35 deps by [@a7i](https://github.com/a7i) in [#1827](kubernetes-sigs/descheduler#1827) - chore: upgrade github.com/gomarkdown/markdown to latest version by [@a7i](https://github.com/a7i) in [#1831](kubernetes-sigs/descheduler#1831) - \[v0.35.0] update docs and manifests by [@a7i](https://github.com/a7i) in [#1832](kubernetes-sigs/descheduler#1832) - Change annotations condition to deploymentAnnotations for Deployment object annotations by [@davidandreoletti](https://github.com/davidandreoletti) in [#1830](kubernetes-sigs/descheduler#1830) ##### New Contributors - [@petersalas](https://github.com/petersalas) made their first contribution in [#1773](kubernetes-sigs/descheduler#1773) - [@Sycrosity](https://github.com/Sycrosity) made their first contribution in [#1772](kubernetes-sigs/descheduler#1772) - [@abelfodil](https://github.com/abelfodil) made their first contribution in [#1764](kubernetes-sigs/descheduler#1764) - [@W1seKappa](https://github.com/W1seKappa) made their first contribution in [#1786](kubernetes-sigs/descheduler#1786) - [@sammedsingalkar09](https://github.com/sammedsingalkar09) made their first contribution in [#1822](kubernetes-sigs/descheduler#1822) - [@davidandreoletti](https://github.com/davidandreoletti) made their first contribution in [#1830](kubernetes-sigs/descheduler#1830) **Full Changelog**: <kubernetes-sigs/descheduler@v0.34.0...v0.35.0> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://gitea.alexlebens.dev/alexlebens/infrastructure/pulls/4099 Co-authored-by: Renovate Bot <renovate-bot@alexlebens.net> Co-committed-by: Renovate Bot <renovate-bot@alexlebens.net>

Copilot AI review requested due to automatic review settings February 4, 2026 11:33

k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 4, 2026

k8s-ci-robot requested review from a7i and ricardomaraschini February 4, 2026 11:33

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 4, 2026

Copilot started reviewing on behalf of ingvagabund February 4, 2026 11:33 View session

refactor(setupPromClientControllerTest): inject context instead of cr…

aa21eed

…eating a stop channel

ingvagabund force-pushed the refactorings branch from c1212fd to 14caf96 Compare February 4, 2026 11:34

format(TestPromClientControllerSync_ClientCreation): indent the code …

760baca

…by two tabs

Copilot AI reviewed Feb 4, 2026

View reviewed changes

test(TestPromClientControllerSync_ClientCreation): have prometheus cl…

a8f618c

…ient tests build an entire descheduler as well

ingvagabund force-pushed the refactorings branch from 14caf96 to a8f618c Compare February 4, 2026 11:43

ingvagabund added 2 commits February 4, 2026 12:47

refactor(TestPromClientControllerSync_EventHandler): get secret name …

818675f

…and namespace from the implicitly generated secret object

format(TestPromClientControllerSync_EventHandler): indent the code by…

4361c13

… two tabs

Copilot AI review requested due to automatic review settings February 4, 2026 12:15

Copilot started reviewing on behalf of ingvagabund February 4, 2026 12:15 View session

test(TestPromClientControllerSync_EventHandler): have prometheus clie…

0822f6f

…nt tests build an entire descheduler as well

ingvagabund force-pushed the refactorings branch from 10fada9 to 0822f6f Compare February 4, 2026 12:18

format(TestReconcileInClusterSAToken): indent the code by two tabs

f8a4efd

Copilot AI reviewed Feb 4, 2026

View reviewed changes

test(TestReconcileInClusterSAToken): have prometheus client tests bui…

c357bc3

…ld an entire descheduler as well

k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 4, 2026

ingvagabund changed the title ~~wip: refactorings~~ test(token reconciling): have tests initialize the prom client reconciling through the descheduler's bootstraping entry too Feb 4, 2026

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 4, 2026

ingvagabund added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 4, 2026

k8s-ci-robot merged commit 5fb70c1 into kubernetes-sigs:master Feb 4, 2026
9 checks passed

ingvagabund deleted the refactorings branch February 4, 2026 13:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test(token reconciling): have tests initialize the prom client reconciling through the descheduler's bootstraping entry too#1820

test(token reconciling): have tests initialize the prom client reconciling through the descheduler's bootstraping entry too#1820
k8s-ci-robot merged 8 commits intokubernetes-sigs:masterfrom
ingvagabund:refactorings

ingvagabund commented Feb 4, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

k8s-ci-robot commented Feb 4, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

ingvagabund commented Feb 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

k8s-ci-robot commented Feb 4, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ingvagabund commented Feb 4, 2026 •

edited

Loading