Allow for installation without cloning the repo.#161
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pravk03 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@ffromani @fmuyassarov This is an optional QOL improvement, please feel free to push back if this is not necessary. |
46fba33 to
fce49ad
Compare
fce49ad to
5badd73
Compare
|
I like the direction of this PR. Allowing users to install the driver without cloning the repository is a real usability improvement, especially for quick testing and staging deployments. |
fmuyassarov
left a comment
There was a problem hiding this comment.
I think this makes sense and is needed. For developers like us, the local chart will still be useful, but having a chart version that can be pulled directly would likely be faster and more convenient.
One thing not to forget (for myself as well), for the official release charts, I think it would make more sense to use the production repository rather than staging. What do you think? In other words, the local chart can remain the default for development and testing, while the production repository would be the source for charts used in official releases.
helm install dra-driver-cpu oci://registry.k8s.io/dra-driver-cpu/charts/dra-driver-cpu --version ${VERSION} -n kube-system
based on this
skopeo list-tags docker://registry.k8s.io/dra-driver-cpu/dra-driver-cpu
{
"Repository": "registry.k8s.io/dra-driver-cpu/dra-driver-cpu",
"Tags": [
"sha256-0ab4277b74a88655b3a344e1939551f815d9729f971459dafef94a4642da4c71.sig",
"sha256-2c3eedbe4c9eed789d15c48cb92ab0b81969e30582098927bc0f8bac6310a535.sig",
"sha256-2f81cbd98adbb24e0f9cb19fef432a80eeacde839cb35af1d41c279d8530182d.sig",
"sha256-3b1ae241c65ed73381e1518e19ef996596086ae77f201d81e8bc1d35a6caae29.sig",
"sha256-a74bef2b40dff4e0aeabe247bd6513152d013932749f8d32c0e39e5e8fb810af.att",
"sha256-a74bef2b40dff4e0aeabe247bd6513152d013932749f8d32c0e39e5e8fb810af.sig",
"v0.1.0"
]
}
| ```bash | ||
| # Deploy the latest staging chart using the mutable 0.0.0-latest tag | ||
| VERSION=0.0.0-latest | ||
| helm install dra-driver-cpu oci://us-central1-docker.pkg.dev/k8s-staging-images/dra-driver-cpu/charts/dra-driver-cpu --version ${VERSION} -n kube-system |
There was a problem hiding this comment.
Since this is from the HEAD, I guess it deserves a little note that it is not for official releases. Because, now the emphasize is on the avoiding the cloning but it may give an impression that this is for the official releases too, which we don't have yet + for the official releases we should use the production registry as I mentioned above.
| # Push a mutable 0.0.0-latest versioned chart tag for easier staging deployments without cloning the repo | ||
| make helm-push \ | ||
| CHART_REGISTRY="${IMG_PREFIX}/charts" \ | ||
| CHART_VERSION="0.0.0-latest" \ | ||
| TAG="${IMG_TAG}" |
There was a problem hiding this comment.
can't we control the CHART_VERSION value from the test-infra to avoid duplication here?
|
Thanks for the comments @AutuSnow @fmuyassarov. Re:
Maybe it makes sense to wait for 0.2.0 (since we are close) and then add instructions to pull the chart directly from the production repos. Maybe we can hold off on this PR. For local development, the current local chart instructions work fine. And for remote/clone-free installations, using official release versions from the production registry is probably the best path anyway. We can also avoid the mutable tag. WDYT ? |
+1 from my side
+1 from my side |
|
/hold |
Currently we need clone the entire repository to install the driver, which can be inconvenient.
This PR publishes a mutable
0.0.0-latesttag for helm chart alongside the commit-specific version and updates the instructions in README to use this.