Make Helm chart portable by removing hardcoded private image registry

[saros-dev]

Problem

The Helm chart currently uses a hardcoded image from a private GCP Artifact Registry:

us-central1-docker.pkg.dev/k8s-staging-images/dra-driver-cpu/dra-driver-cpu:latest

This causes ImagePullBackOff for contributors who do not have access to the registry.

Impact

• Blocks external contributors from running the chart
• Makes local testing impossible without GCP authentication
• Reduces portability of the project

Changes in this PR

• Made image configuration fully customizable via values.yaml
• Added support for imagePullSecrets
• Removed hardcoded dependency on private registry assumptions

How to test

helm template ./deployment/helm/dra-driver-cpu

Notes

This change improves chart portability without changing default behavior for existing users.
This change is backward compatible and does not modify default behavior.
Happy to adjust this if maintainers prefer a different approach.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: saros-dev
Once this PR has been reviewed and has the lgtm label, please assign johnbelamaric for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: saros-dev / name: saros-dev (ca542ee, d54df0c)

[k8s-ci-robot]

Welcome @saros-dev!

It looks like this is your first PR to kubernetes-sigs/dra-driver-cpu 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/dra-driver-cpu has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @saros-dev. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[saros-dev]

Thanks for the review requests.

I have completed the CLA authorization. Please let me know if any additional changes are needed.

Thank you!

[ffromani]

/ok-to-test

[ffromani]

Thanks for your PR!
Improving devex/ux is surely something we want to do, and indeed we can have better defaults. Likely, we should default to the previous released version by default and document how to point to a custom-built development version.
That said, unfortunately it is not obvious to me how the PR solves the problem you are describing. Perhaps you could maybe elaborate a bit?

[ffromani]

I think this should be left "" because this way helm can fall back to .Chart.AppVersion. Then yes, nowadays .Chart.Appversion is latest, but I think we want to keep the indirection

[ffromani]

I think --set image.repository should already allow to override this value. Is that the case? is there another issue which is eluding us?

[saros-dev]

Thanks for the review.

The issue I encountered was during a clean Helm installation using the chart defaults. The resulting DaemonSet attempted to pull the image from:

us-central1-docker.pkg.dev/k8s-staging-images/dra-driver-cpu/dra-driver-cpu

and consistently failed with ImagePullBackOff due to 403 Forbidden responses from the registry.

My initial assumption was that the chart defaults should point to an image that is directly consumable by users evaluating the project or running it in local development environments. Based on that assumption, I proposed changing the default repository to avoid the dependency on the staging registry.

That said, I understand your point that image.repository is already configurable via values or --set, and that changing the default repository may not be the right solution if the current staging image is intentionally used as the canonical default.

Perhaps a better approach would be to document the expected workflow for local development and clarify which image repository users should override to when deploying the chart outside of the Kubernetes release infrastructure.

I am happy to adjust the PR direction if documentation or another approach would be preferred.