Adding imagepullsecret and pullpolicy for MPS deployment#1175
Adding imagepullsecret and pullpolicy for MPS deployment#1175visheshtanksale wants to merge 1 commit into
Conversation
Signed-off-by: Vishesh Tanksale <vtanksale@nvidia.com>
✅ Deploy Preview for dra-driver-nvidia-gpu ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: visheshtanksale The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/retest |
|
@visheshtanksale: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| EnvVars: []string{"IMAGE_NAME"}, | ||
| }, | ||
| &cli.StringFlag{ | ||
| Name: "mps-control-daemon-image-pull-secret-names", |
There was a problem hiding this comment.
Can we generalize these as IMAGE_PULL_POLICY and IMAGE_PULL_SECRETS instead, as they can be used for any non-mps pods that we might manage in the future.
| flags: flags, | ||
| clientsets: clientSets, | ||
| mpsControlDaemonPullSecretNames: strings.Fields(strings.ReplaceAll(strings.TrimSpace(flags.mpsControlDaemonPullSecrets), ",", " ")), | ||
| mpsControlDaemonImagePullPolicy: strings.TrimSpace(flags.mpsControlDaemonPullPolicy), |
There was a problem hiding this comment.
Additional field in the config for mpsControlDaemonImagePullPolicy seem unnecessary here.
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
The MPS control daemon Deployment did not honor the chart's image pull configuration, so its pod could not pull the driver image from a private registry, and its pull policy was left to the Kubernetes default inferred from
the image tag.
This PR plumbs image pull settings through to the MPS control daemon pod spec:
Which issue(s) this PR is related to:
Fixes #1045
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation (design docs, usage docs, etc.):
Checklist
make check testpasses locallymake check-generatepasses ifapi/changed (CRDs, deepcopy, informers, listers, clientset)make check-modulespasses ifgo.mod/go.sumchangeddeployments/helm) updated if flags, RBAC, or defaults changed