Skip to content

Adding imagepullsecret and pullpolicy for MPS deployment#1175

Open
visheshtanksale wants to merge 1 commit into
kubernetes-sigs:mainfrom
visheshtanksale:image-pullsecret-mps
Open

Adding imagepullsecret and pullpolicy for MPS deployment#1175
visheshtanksale wants to merge 1 commit into
kubernetes-sigs:mainfrom
visheshtanksale:image-pullsecret-mps

Conversation

@visheshtanksale
Copy link
Copy Markdown
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:

The MPS control daemon Deployment did not honor the chart's image pull configuration, so its pod could not pull the driver image from a private registry, and its pull policy was left to the Kubernetes default inferred from
the image tag.

This PR plumbs image pull settings through to the MPS control daemon pod spec:

Which issue(s) this PR is related to:

Fixes #1045

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Two new gpu-kubelet-plugin flags/env vars are added:
`--mps-control-daemon-image-pull-secret-names` /
`MPS_CONTROL_DAEMON_IMAGE_PULL_SECRET_NAMES` and
`--mps-control-daemon-image-pull-policy` /
`MPS_CONTROL_DAEMON_IMAGE_PULL_POLICY`. 
These are set automatically by the Helm chart from existing `imagePullSecrets` and `image.pullPolicy` values; no action
is required on upgrade.

Additional documentation (design docs, usage docs, etc.):


Checklist

  • make check test passes locally
  • make check-generate passes if api/ changed (CRDs, deepcopy, informers, listers, clientset)
  • make check-modules passes if go.mod / go.sum changed
  • Tests added or updated for the change
  • Helm chart (deployments/helm) updated if flags, RBAC, or defaults changed

Signed-off-by: Vishesh Tanksale <vtanksale@nvidia.com>
@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jun 4, 2026
@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jun 4, 2026
@netlify
Copy link
Copy Markdown

netlify Bot commented Jun 4, 2026

Deploy Preview for dra-driver-nvidia-gpu ready!

Name Link
🔨 Latest commit f1d7590
🔍 Latest deploy log https://app.netlify.com/projects/dra-driver-nvidia-gpu/deploys/6a20c42d312ac80008dfd799
😎 Deploy Preview https://deploy-preview-1175--dra-driver-nvidia-gpu.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: visheshtanksale
Once this PR has been reviewed and has the lgtm label, please assign varunrsekar for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 4, 2026
@shivamerla
Copy link
Copy Markdown
Contributor

/retest

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

@visheshtanksale: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-dra-driver-nvidia-gpu-e2e-lambda-gpu f1d7590 link false /test pull-dra-driver-nvidia-gpu-e2e-lambda-gpu
pull-dra-driver-nvidia-gpu-e2e-lambda-gpu-gh200 f1d7590 link false /test pull-dra-driver-nvidia-gpu-e2e-lambda-gpu-gh200

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

EnvVars: []string{"IMAGE_NAME"},
},
&cli.StringFlag{
Name: "mps-control-daemon-image-pull-secret-names",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we generalize these as IMAGE_PULL_POLICY and IMAGE_PULL_SECRETS instead, as they can be used for any non-mps pods that we might manage in the future.

flags: flags,
clientsets: clientSets,
mpsControlDaemonPullSecretNames: strings.Fields(strings.ReplaceAll(strings.TrimSpace(flags.mpsControlDaemonPullSecrets), ",", " ")),
mpsControlDaemonImagePullPolicy: strings.TrimSpace(flags.mpsControlDaemonPullPolicy),
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional field in the config for mpsControlDaemonImagePullPolicy seem unnecessary here.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 6, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

[Bug]: MPS DaemonSet missing imagePullSecrets causes ImagePullBackOff on Kubernetes 1.35+

3 participants