Revert daemon status updates from SSA to optimistic concurrency#835
Merged
Conversation
jgehrcke
reviewed
Jan 28, 2026
| return nil, fmt.Errorf("error getting next available index: %w", err) | ||
| } | ||
| myDaemon.Index = idx | ||
| klog.V(4).Infof("syncDaemonInfoToClique: IMEX daemon not started yet, DNS index collision with %v, picked new index: %d", other, idx) |
Contributor
|
I had a quick look at the last commit (the SSA removal). Already looks good. |
Signed-off-by: Kevin Klues <kklues@nvidia.com>
jgehrcke
approved these changes
Jan 28, 2026
Contributor
jgehrcke
left a comment
jgehrcke
left a comment
There was a problem hiding this comment.
Looks great!
(full test suite passes)
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace Server-Side Apply (SSA) with traditional Update/UpdateStatus
calls using optimistic concurrency in the compute-domain-daemon. This
aligns with the pre-SSA implementation pattern and simplifies the
conflict resolution model by relying on Kubernetes resource versions.
Key changes:
Update/UpdateStatus calls with optimistic concurrency
owner reference, using workqueue retry logic
with syncDaemonInfoToClique
validation pattern in cdstatus.go
The CDClique is created with labels: