Skip to content

internal/common: guard SIGUSR2 debug handler on Windows#863

Closed
AkshatDudeja77 wants to merge 1 commit into
kubernetes-sigs:mainfrom
AkshatDudeja77:small-error-wrap-common
Closed

internal/common: guard SIGUSR2 debug handler on Windows#863
AkshatDudeja77 wants to merge 1 commit into
kubernetes-sigs:mainfrom
AkshatDudeja77:small-error-wrap-common

Conversation

@AkshatDudeja77

Copy link
Copy Markdown

This change disables the SIGUSR2-based debug signal handler on Windows.

Windows does not support SIGUSR2, which causes build failures due to
syscall.SIGUSR2 being undefined. The handler is now conditionally skipped
at runtime on Windows while preserving existing behavior on Unix-like
platforms.

No functional changes on Linux.

Signed-off-by: AkshatDudeja77 <akshat.dudeja77@gmail.com>
@copy-pr-bot

copy-pr-bot Bot commented Feb 8, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@klueska

klueska commented Feb 8, 2026

Copy link
Copy Markdown
Contributor

IMEX is only supported on Linux

@AkshatDudeja77

Copy link
Copy Markdown
Author

IMEX is only supported on Linux

Yes, agreed that IMEX is Linux-only.

This change does not attempt to support Windows. It only guards the debug SIGUSR2 handler to avoid build/runtime issues when the codebase is analyzed or built on Windows (where SIGUSR2 is undefined), while preserving identical behavior on Linux.

There is no functional impact on Linux paths.

@rajatchopra

Copy link
Copy Markdown
Contributor

Thanks for the initiative @AkshatDudeja77.
Closing this PR at this point. Windows is a non-starter for a lot of code here already. We need a bigger redesign of code to let any functional subset to work.
Just not allowing the sighandlers to be registered for windows is noisy. The right way would be to have an interface implemented for linux and others separately and plugged in appropriately for the platform in question.

Feel free though to re-open if you think otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants