Skip to content

Conversation

mloiseleur
Copy link
Collaborator

Description

It explains to users how to test a PR.

Checklist

  • Unit tests updated
  • End user documentation updated

@mloiseleur mloiseleur added the kind/documentation Categorizes issue or PR as related to documentation. label May 21, 2025
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 21, 2025
@k8s-ci-robot k8s-ci-robot requested a review from szuecs May 21, 2025 10:57
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 21, 2025
Copy link
Contributor

@ivankatliarchuk ivankatliarchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 21, 2025
@ivankatliarchuk
Copy link
Contributor

@mloiseleur
Copy link
Collaborator Author

There is as well this document https://github.com/kubernetes-sigs/external-dns/blob/master/docs/contributing/dev-guide.md

It's more for users than for developers. The contributing section in readme references both, so I think we're good.

Maybe we need to add this links to pull request template ? https://github.com/kubernetes-sigs/external-dns/blob/master/.github/pull_request_template.md

I'm not sure 🤔. I'll open an other PR to update it, let's see if we can insert it in a convenient way.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ivankatliarchuk, mloiseleur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 21, 2025
@k8s-ci-robot k8s-ci-robot merged commit cc0d723 into kubernetes-sigs:master May 21, 2025
16 checks passed
@mloiseleur mloiseleur deleted the docs/test-pr branch May 22, 2025 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants