Skip to content

fix: Properly install the InferenceModelRewrite CRD using kustomize#1934

Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
shmuelk:crds-fix
Dec 2, 2025
Merged

fix: Properly install the InferenceModelRewrite CRD using kustomize#1934
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
shmuelk:crds-fix

Conversation

@shmuelk
Copy link
Copy Markdown
Contributor

@shmuelk shmuelk commented Dec 2, 2025

What type of PR is this?
/kind bug

What this PR does / why we need it:
Properly install all GIE CRDs per the instaructions.

Which issue(s) this PR fixes:
Fixes #1933

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Dec 2, 2025
@netlify
Copy link
Copy Markdown

netlify bot commented Dec 2, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit bd1fcac
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/692f0704de94de0008d5c98f
😎 Deploy Preview https://deploy-preview-1934--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 2, 2025
@nirrozenbaum
Copy link
Copy Markdown
Contributor

great catch!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 2, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nirrozenbaum, shmuelk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 2, 2025
@k8s-ci-robot k8s-ci-robot merged commit cf06da1 into kubernetes-sigs:main Dec 2, 2025
12 checks passed
@nirrozenbaum nirrozenbaum mentioned this pull request Dec 4, 2025
nirrozenbaum pushed a commit that referenced this pull request Dec 4, 2025
Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
@shmuelk shmuelk deleted the crds-fix branch December 10, 2025 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Kustomize build to install the GIE CRDs does not install the new InferenceModelRewrite CRD

3 participants