Skip to content

feat(modelRewrite): Add metrics for InferenceModelRewrite decisions#1938

Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
zetxqx:modlrewritemetrics
Dec 3, 2025
Merged

feat(modelRewrite): Add metrics for InferenceModelRewrite decisions#1938
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
zetxqx:modlrewritemetrics

Conversation

@zetxqx
Copy link
Copy Markdown
Contributor

@zetxqx zetxqx commented Dec 3, 2025

What type of PR is this?

/kind feature

adds observability for the Inference Model Rewrite feature by introducing a new counter metric model_rewrite_decisions_total. This metric tracks the number of times a specific model rewrite rule is applied, including details about the original model, the target model, and the rewrite rule resource name

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1926

Does this PR introduce a user-facing change?:

Add metrics model_rewrite_decisions_total for modelRewrite observability.

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 3, 2025
@netlify
Copy link
Copy Markdown

netlify bot commented Dec 3, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 86ba695
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/692f871885c1fe00085c76f0
😎 Deploy Preview https://deploy-preview-1938--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 3, 2025
@zetxqx zetxqx force-pushed the modlrewritemetrics branch from f7e052f to 86ba695 Compare December 3, 2025 00:40
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 3, 2025
@zetxqx
Copy link
Copy Markdown
Contributor Author

zetxqx commented Dec 3, 2025

/cc @ahg-g

@k8s-ci-robot k8s-ci-robot requested a review from ahg-g December 3, 2025 01:04
@shmuelk
Copy link
Copy Markdown
Contributor

shmuelk commented Dec 3, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 3, 2025
@ahg-g
Copy link
Copy Markdown
Contributor

ahg-g commented Dec 3, 2025

/approve

thanks

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, zetxqx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 3, 2025
@k8s-ci-robot k8s-ci-robot merged commit cbbfd0e into kubernetes-sigs:main Dec 3, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement observability metrics for Inference Model Rewrite and Traffic Splitting

4 participants