Skip to content

Move AllPodsPredicate to datastore package#1939

Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
elevran:all_pods_predicate
Dec 3, 2025
Merged

Move AllPodsPredicate to datastore package#1939
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
elevran:all_pods_predicate

Conversation

@elevran
Copy link
Copy Markdown
Contributor

@elevran elevran commented Dec 3, 2025

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
The PR moves the PodList() predicate listing all pods from backend/metrics to datastore package.
The listing predicate is more of a datastore option than a feature of the backend/metrics object

Which issue(s) this PR fixes:
NA

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Dec 3, 2025
@k8s-ci-robot k8s-ci-robot requested review from ahg-g and kfswain December 3, 2025 13:46
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 3, 2025
@netlify
Copy link
Copy Markdown

netlify bot commented Dec 3, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit e6d6e66
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/69303f46f370c400080fb678
😎 Deploy Preview https://deploy-preview-1939--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@nirrozenbaum
Copy link
Copy Markdown
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 3, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elevran, nirrozenbaum

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 3, 2025
@k8s-ci-robot k8s-ci-robot merged commit 2b49026 into kubernetes-sigs:main Dec 3, 2025
15 checks passed
@elevran elevran deleted the all_pods_predicate branch December 3, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants