Skip to content

Separate conformance tests modules from main tests#1994

Merged
k8s-ci-robot merged 3 commits intokubernetes-sigs:mainfrom
rikatz:separate-modules
Jan 15, 2026
Merged

Separate conformance tests modules from main tests#1994
k8s-ci-robot merged 3 commits intokubernetes-sigs:mainfrom
rikatz:separate-modules

Conversation

@rikatz
Copy link
Copy Markdown
Member

@rikatz rikatz commented Dec 12, 2025

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Separate conformance test modules from main modules, removing the dependency of Gateway API version.

Which issue(s) this PR fixes:

NONE

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Dec 12, 2025
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 12, 2025
@rikatz
Copy link
Copy Markdown
Member Author

rikatz commented Dec 12, 2025

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 12, 2025
@netlify
Copy link
Copy Markdown

netlify bot commented Dec 12, 2025 •
edited
Loading

✅ Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 7c3bda0
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/69692c2703140900087376e2
😎 Deploy Preview https://deploy-preview-1994--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@rikatz
Copy link
Copy Markdown
Member Author

rikatz commented Dec 12, 2025

/cc @jaellio

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Dec 12, 2025

@rikatz: GitHub didn't allow me to request PR reviews from the following users: jaellio.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

/cc @jaellio

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kfswain
Copy link
Copy Markdown
Collaborator

kfswain commented Dec 15, 2025

Separate conformance test modules from main modules, removing the dependency of Gateway API version.

<3 <3 <3

/approve

I see a hold on here, so will hold off on LGTM and let others give final stamp. But this is great. Thank you so much!

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 15, 2025
@kfswain kfswain mentioned this pull request Dec 15, 2025
Closed
@rikatz
Copy link
Copy Markdown
Member Author

rikatz commented Dec 15, 2025

a heads up I didn't had time to tackle, https://github.com/kubernetes-sigs/gateway-api-inference-extension/blob/main/.github/dependabot.yml may need some updates as well (as @mikemorris also identified on GW API today).

If no one arrives on this PR by tomorrow I will try to fix it, otherwise I can do as a followup

jaellio
jaellio reviewed Dec 18, 2025
View reviewed changes
conformance/go.mod Outdated
replace sigs.k8s.io/gateway-api-inference-extension => ../

require (
sigs.k8s.io/gateway-api v1.3.1-0.20251106052652-079e4774d76b
Copy link
Copy Markdown

@jaellio jaellio Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we update this to the latest version (1.4)?

Copy link
Copy Markdown
Member Author

@rikatz rikatz Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jaellio updating the Gateway API version kinds of break the conformance because creq.HTTPPort is not available. I will check which commit removed it and what this was replaced for, but maybe it is worth doing on a different PR? Otherwise I can do it :)

Copy link
Copy Markdown
Member Author

@rikatz rikatz Dec 22, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I can see this is at main and even being called v1.3.1 it is indeed pointing to a commit from monthly release (https://github.com/kubernetes-sigs/gateway-api/releases/tag/monthly-2025.12) so we may be good to go

Copy link
Copy Markdown
Contributor

@shmuelk shmuelk Dec 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rikatz An inspection of the https://github.com/kubernetes-sigs/gateway-api at tag v1.4.1 shows that commit kubernetes-sigs/gateway-api@079e477 is indeed merged in that release

Copy link
Copy Markdown
Member Author

@rikatz rikatz Jan 2, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hum I just checked the tag: https://github.com/kubernetes-sigs/gateway-api/blob/v1.4.1/conformance/echo-basic/echo-basic.go

It is tagged as monthly, but not as 1.4.1

@zetxqx
Copy link
Copy Markdown
Contributor

zetxqx commented Dec 20, 2025

/lgtm
ty!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 20, 2025
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 30, 2025
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 2, 2026
@rikatz
Copy link
Copy Markdown
Member Author

rikatz commented Jan 2, 2026

Done again. As a suggestion, you may want to separate all of the BBR, EPP code (and packages) from the main API, otherwise someone consuming GIE API will get the whole go.mod from the main directory.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 6, 2026
@kfswain
Copy link
Copy Markdown
Collaborator

kfswain commented Jan 15, 2026

/approve

nirrozenbaum
nirrozenbaum approved these changes Jan 15, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@nirrozenbaum nirrozenbaum left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

please rebase so we can merge 🙏🏼

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 15, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jan 15, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kfswain, nirrozenbaum, rikatz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [kfswain,nirrozenbaum]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 15, 2026
@zetxqx
Copy link
Copy Markdown
Contributor

zetxqx commented Jan 15, 2026

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 15, 2026
@danehans
Copy link
Copy Markdown
Contributor

danehans commented Jan 15, 2026

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 15, 2026
@k8s-ci-robot k8s-ci-robot merged commit 85517e6 into kubernetes-sigs:main Jan 15, 2026
11 checks passed
RyanRosario pushed a commit to RyanRosario/gateway-api-inference-extension that referenced this pull request Jan 20, 2026
@rikatz @RyanRosario
Separate conformance tests modules from main tests (kubernetes-sigs#1994
3a08811 
)

* Separate conformance tests modules from main tests

* Add tidy as part of make generate

* Rebase and point gw api to monthly-2025.12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nirrozenbaum nirrozenbaum nirrozenbaum approved these changes

@ahg-g ahg-g Awaiting requested review from ahg-g

@shmuelk shmuelk Awaiting requested review from shmuelk

+1 more reviewer

@jaellio jaellio jaellio left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@nirrozenbaum nirrozenbaum

@zetxqx zetxqx

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@rikatz @k8s-ci-robot @kfswain @zetxqx @danehans @shmuelk @nirrozenbaum @jaellio