generated from kubernetes/kubernetes-template-project
-
Notifications
You must be signed in to change notification settings - Fork 221
Add flowcontrol queue length in bytes metric #2044
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
RyanRosario
wants to merge
2
commits into
kubernetes-sigs:main
Choose a base branch
from
RyanRosario:bytemetric
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+68
−0
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -973,6 +973,44 @@ func TestFlowControlQueueSizeMetric(t *testing.T) { | |
| require.Equal(t, 0.0, val, "Gauge value for non-existent labels should be 0") | ||
| } | ||
|
|
||
| func TestFlowControlQueueBytesMetric(t *testing.T) { | ||
| Reset() | ||
|
|
||
| const ( | ||
| pool = "pool-1" | ||
| model = "llama-2" | ||
| target = "llama-base" | ||
| ) | ||
|
|
||
| // Basic Inc/Dec | ||
| AddFlowControlQueueBytes("user-a", "100", pool, model, target, 32.0) | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: The helper function |
||
| val, err := testutil.GetGaugeMetricValue(flowControlQueueBytes.WithLabelValues("user-a", "100", pool, model, target)) | ||
| require.NoError(t, err, "Failed to get gauge value for user-a/100 after Inc") | ||
| require.Equal(t, 32.0, val, "Gauge value should be 32 after Add for user-a/100") | ||
|
|
||
| SubFlowControlQueueBytes("user-a", "100", pool, model, target, 32) | ||
| val, err = testutil.GetGaugeMetricValue(flowControlQueueBytes.WithLabelValues("user-a", "100", pool, model, target)) | ||
| require.NoError(t, err, "Failed to get gauge value for user-a/100 after Sub") | ||
| require.Equal(t, 0.0, val, "Gauge value should be 0 after Sub for user-a/100") | ||
|
|
||
| // Multiple labels | ||
| AddFlowControlQueueBytes("user-b", "200", pool, model, target, 32.0) | ||
| AddFlowControlQueueBytes("user-b", "200", pool, model, target, 16.0) | ||
| val, err = testutil.GetGaugeMetricValue(flowControlQueueBytes.WithLabelValues("user-b", "200", pool, model, target)) | ||
| require.NoError(t, err, "Failed to get gauge value for user-b/200") | ||
| require.Equal(t, 48.0, val, "Gauge value should be 48 for user-b/200") | ||
|
|
||
| SubFlowControlQueueBytes("user-b", "200", pool, model, target, 48.0) | ||
| val, err = testutil.GetGaugeMetricValue(flowControlQueueBytes.WithLabelValues("user-b", "200", pool, model, target)) | ||
| require.NoError(t, err, "Failed to get gauge value for user-b/200 after one Sub") | ||
| require.Equal(t, 0.0, val, "Gauge value should be 0 for user-b/200 after one Sub") | ||
|
|
||
| // Non-existent labels | ||
| val, err = testutil.GetGaugeMetricValue(flowControlQueueBytes.WithLabelValues("user-c", "100", pool, model, target)) | ||
| require.NoError(t, err, "Failed to get gauge value for non-existent user-c/100") | ||
| require.Equal(t, 0.0, val, "Gauge value for non-existent labels should be 0") | ||
| } | ||
|
|
||
| func TestInferenceModelRewriteDecisionsTotalMetric(t *testing.T) { | ||
| Reset() | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Even though
req.ByteSize()is technically immutable right now, it is a defensive best practice to capture the size in a local variable before the defer.This guarantees that the
AddandSuboperations are always mathematically symmetric. If a future refactor makes changes howByteSize()is calculated (making it mutable), we risk the Gauge drifting permanently (e.g., subtracting more than we added or vice versa).