cleanup: rename integration test utilities to remove _test suffix#2084
Conversation
Renames harness and utility files (e.g., harness_test.go -> harness.go) within the EPP integration test suite to align with project conventions. Additionally moves shared global variables (k8sClient, testEnv) to harness.go to ensure visibility for the renamed files, resolving compiler scope issues that arise when separating test logic from infrastructure code.
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Hi @LukeAVanDrie. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahg-g, LukeAVanDrie The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR renames utility and harness files within the EPP integration test suite to align with project conventions and fix linting issues.
Previously,
harness.goandutil.gocarried the_test.gosuffix. While this correctly excluded them from the production binary via build constraints, it violated the convention that_test.gofiles should primarily contain test functions.Changes:
harness_test.go->harness.go,util_test.go->util.go.k8sClient,testEnv, etc.) fromhermetic_test.gotoharness.go. This ensures that the newly renamed (non-test) files can compile and access these shared resources without import cycles or scope visibility errors.cleanMetrichelper toutil.go.Which issue(s) this PR fixes:
Follow-up to feedback from PR #2022.
Does this PR introduce a user-facing change?: