Fixed targetPorts copy error#2092
Conversation
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XS
|
Thanks for @LukeAVanDrie for finding the root cause of regression failure of EPP standalone mode! |
|
/assign @kfswain |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: capri-xiyue, nirrozenbaum The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
Thanks for the fix! |
|
/cherrypick release-1.3 |
|
@kfswain: new pull request created: #2093 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherrypick release-1.3 |
|
@kfswain: new pull request created: #2099 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherrypick release-1.3 Last time! We were trying out some new automation that wasnt quite working. Sorry for the spam. |
|
@kfswain: new pull request created: #2107 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
5 participants
What type of PR is this?
/kind bug
What this PR does / why we need it:
The error copy brought regression failure to epp standalone mode.
https://pkg.go.dev/builtin#copy Copy returns the number of elements copied, which will be the minimum of len(src) and len(dst) however in original code the dst is initialized to len 0, therefore no elements got copied and brought the bug.
Which issue(s) this PR fixes:
Fixed the regression failure of EPP standalone mode
Does this PR introduce a user-facing change?: