Skip to content

add scoring preference to scorer interface.#2119

Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
nirrozenbaum:scoring-preference
Jan 12, 2026
Merged

add scoring preference to scorer interface.#2119
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
nirrozenbaum:scoring-preference

Conversation

@nirrozenbaum
Copy link
Copy Markdown
Contributor

this is a pre-req for adapting scorer weights

What type of PR is this?
/kind feature

What this PR does / why we need it:
This is a pre-req for experimenting with #1992.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

When implementing a scorer, the developer should declare if the scorer preference is affinity based on some cache or other state, or even load distribution.
Not changing anything in the user experience, only for the developer of scorers.

/cc @kfswain @vMaroon

@k8s-ci-robot k8s-ci-robot requested a review from kfswain January 11, 2026 08:09
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 11, 2026
@netlify
Copy link
Copy Markdown

netlify bot commented Jan 11, 2026

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 996f017
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/69650b18ae77020008154703
😎 Deploy Preview https://deploy-preview-2119--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nirrozenbaum

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 11, 2026
@kubernetes-sigs kubernetes-sigs deleted a comment from k8s-ci-robot Jan 11, 2026
@nirrozenbaum
Copy link
Copy Markdown
Contributor Author

@vMaroon updated names

@kfswain
Copy link
Copy Markdown
Collaborator

kfswain commented Jan 12, 2026

/lgtm

I think this is a great step towards understanding scorers better, thanks Nir!

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 12, 2026
Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 12, 2026
@nirrozenbaum
Copy link
Copy Markdown
Contributor Author

rebased

@kfswain
Copy link
Copy Markdown
Collaborator

kfswain commented Jan 12, 2026

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 12, 2026
@k8s-ci-robot k8s-ci-robot merged commit 75c3897 into kubernetes-sigs:main Jan 12, 2026
11 checks passed
@nirrozenbaum nirrozenbaum deleted the scoring-preference branch January 12, 2026 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants