Flow Control: Ordering Policy Migration (Phase 1)#2188
Flow Control: Ordering Policy Migration (Phase 1)#2188k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
Conversation
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
71653fb to
9faf1e6
Compare
|
/assign @ahg-g This is a continuation of the EPP plugin model alignment work I started with #2031. I am now applying this pattern to |
|
cc: @RyanRosario |
|
/approve pls rebase |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahg-g, LukeAVanDrie The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
9faf1e6 to
d267943
Compare
This commit introduces the foundation for the Ordering Policy migration. It defines the new Comparator-centric OrderingPolicy interface and updates the FCFS and EDF plugins to implement it, while maintaining backward compatibility with `IntraFlowDispatchPolicy`. Specific changes: - framework: define OrderingPolicy interface in `plugins.go`. - intraflow: rename constants to `...OrderingPolicyType`. - registry: update default config to use new constant names. - doc: update framework and intraflow documentation.
d267943 to
3e637a7
Compare
|
/lgtm |
…i-inference-extension#2188) This commit introduces the foundation for the Ordering Policy migration. It defines the new Comparator-centric OrderingPolicy interface and updates the FCFS and EDF plugins to implement it, while maintaining backward compatibility with `IntraFlowDispatchPolicy`. Specific changes: - framework: define OrderingPolicy interface in `plugins.go`. - intraflow: rename constants to `...OrderingPolicyType`. - registry: update default config to use new constant names. - doc: update framework and intraflow documentation.
What type of PR is this?
/kind feature
/kind cleanup
What this PR does / why we need it:
This PR implements Phase 1 of the Flow Control Layer's migration from
IntraFlowDispatchPolicyto the newOrderingPolicyinterface.Changes:
framework.OrderingPolicyinplugins.go, which uses aLess(a, b)method instead of the legacySelectItemindirection.FCFSandEDFpolicies to implement the new interface while maintaining strict backward compatibility with the existingIntraFlowDispatchPolicy....OrderingPolicyTypefor consistency with the EPP Plugin Architecture (matchinginterflowpatterns).Migration Strategy:
This is an additive change only. It sets the stage for Phase 2, where
ManagedQueueandRegistrywill be updated to purely use the new interface.Which issue(s) this PR fixes:
Part of #1715
Does this PR introduce a user-facing change?: