Skip to content

Flow Control: Ordering Policy Migration (Phase 1)#2188

Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
LukeAVanDrie:refactor/ordering-policy
Jan 23, 2026
Merged

Flow Control: Ordering Policy Migration (Phase 1)#2188
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
LukeAVanDrie:refactor/ordering-policy

Conversation

@LukeAVanDrie
Copy link
Copy Markdown
Contributor

What type of PR is this?

/kind feature
/kind cleanup

What this PR does / why we need it:

This PR implements Phase 1 of the Flow Control Layer's migration from IntraFlowDispatchPolicy to the new OrderingPolicy interface.

Changes:

  • Defines framework.OrderingPolicy in plugins.go, which uses a Less(a, b) method instead of the legacy SelectItem indirection.
  • Updates FCFS and EDF policies to implement the new interface while maintaining strict backward compatibility with the existing IntraFlowDispatchPolicy.
  • Renames policy constants to ...OrderingPolicyType for consistency with the EPP Plugin Architecture (matching interflow patterns).

Migration Strategy:

This is an additive change only. It sets the stage for Phase 2, where ManagedQueue and Registry will be updated to purely use the new interface.

Which issue(s) this PR fixes:

Part of #1715

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 20, 2026
@netlify
Copy link
Copy Markdown

netlify Bot commented Jan 20, 2026

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 3e637a7
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/6973d48dadddbe0008ab68f2
😎 Deploy Preview https://deploy-preview-2188--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 20, 2026
@LukeAVanDrie LukeAVanDrie force-pushed the refactor/ordering-policy branch from 71653fb to 9faf1e6 Compare January 20, 2026 23:01
@LukeAVanDrie
Copy link
Copy Markdown
Contributor Author

/assign @ahg-g

This is a continuation of the EPP plugin model alignment work I started with #2031. I am now applying this pattern to Ordering policies (formerly, IntraFlowDispatchPolicy). I have broken it into smaller, stacked PRs this time. This is primarily documentation and new type definitions. The next PR will perform the "switch" between the old and new model.

@LukeAVanDrie
Copy link
Copy Markdown
Contributor Author

cc: @RyanRosario

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 23, 2026
@ahg-g
Copy link
Copy Markdown
Contributor

ahg-g commented Jan 23, 2026

/approve

pls rebase

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, LukeAVanDrie

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 23, 2026
@LukeAVanDrie LukeAVanDrie force-pushed the refactor/ordering-policy branch from 9faf1e6 to d267943 Compare January 23, 2026 20:02
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 23, 2026
This commit introduces the foundation for the Ordering Policy migration.
It defines the new Comparator-centric OrderingPolicy interface and
updates the FCFS and EDF plugins to implement it, while maintaining
backward compatibility with `IntraFlowDispatchPolicy`.

Specific changes:
- framework: define OrderingPolicy interface in `plugins.go`.
- intraflow: rename constants to `...OrderingPolicyType`.
- registry: update default config to use new constant names.
- doc: update framework and intraflow documentation.
@LukeAVanDrie LukeAVanDrie force-pushed the refactor/ordering-policy branch from d267943 to 3e637a7 Compare January 23, 2026 20:05
@ahg-g
Copy link
Copy Markdown
Contributor

ahg-g commented Jan 23, 2026

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 23, 2026
@k8s-ci-robot k8s-ci-robot merged commit bbee4b6 into kubernetes-sigs:main Jan 23, 2026
11 checks passed
elevran pushed a commit to llm-d/llm-d-inference-scheduler that referenced this pull request Apr 23, 2026
…i-inference-extension#2188)

This commit introduces the foundation for the Ordering Policy migration.
It defines the new Comparator-centric OrderingPolicy interface and
updates the FCFS and EDF plugins to implement it, while maintaining
backward compatibility with `IntraFlowDispatchPolicy`.

Specific changes:
- framework: define OrderingPolicy interface in `plugins.go`.
- intraflow: rename constants to `...OrderingPolicyType`.
- registry: update default config to use new constant names.
- doc: update framework and intraflow documentation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants