Skip to content

align attritbute reporter with plugins structure#2290

Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
nirrozenbaum:rm-logger
Feb 8, 2026
Merged

align attritbute reporter with plugins structure#2290
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
nirrozenbaum:rm-logger

Conversation

@nirrozenbaum
Copy link
Copy Markdown
Contributor

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
align attribute reporter plugin with how plugins are structured.
in a follow up, error should propagate up instead of logging in helper functions.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

None

Signed-off-by: Nir Rozenbaum <nrozenba@redhat.com>
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 8, 2026
@k8s-ci-robot k8s-ci-robot requested a review from kfswain February 8, 2026 12:59
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nirrozenbaum

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from shmuelk February 8, 2026 12:59
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 8, 2026
@nirrozenbaum
Copy link
Copy Markdown
Contributor Author

/cc @ahg-g

@k8s-ci-robot k8s-ci-robot requested a review from ahg-g February 8, 2026 12:59
@nirrozenbaum nirrozenbaum changed the title align attritbute reporter plugin structure align attritbute reporter with plugins structure Feb 8, 2026
@netlify
Copy link
Copy Markdown

netlify Bot commented Feb 8, 2026

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit ef501fd
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/698888b8a1219800075469b7
😎 Deploy Preview https://deploy-preview-2290--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@ahg-g
Copy link
Copy Markdown
Contributor

ahg-g commented Feb 8, 2026

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 8, 2026
@k8s-ci-robot k8s-ci-robot merged commit 249c208 into kubernetes-sigs:main Feb 8, 2026
13 checks passed
@nirrozenbaum nirrozenbaum deleted the rm-logger branch February 8, 2026 18:03
RyanRosario pushed a commit to RyanRosario/gateway-api-inference-extension that referenced this pull request Mar 9, 2026
Signed-off-by: Nir Rozenbaum <nrozenba@redhat.com>
elevran pushed a commit to llm-d/llm-d-inference-scheduler that referenced this pull request Apr 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants