add PopulateControllerConfig in runner.go#2300
add PopulateControllerConfig in runner.go#2300k8s-ci-robot merged 9 commits intokubernetes-sigs:mainfrom
Conversation
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahg-g, kaushikmitr The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
is a patch release planned? |
|
/cherrypick release-1.3 |
|
@kfswain: #2300 failed to apply on top of branch "release-1.3": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
* add priority to admit request * add inference obj spec to llmrequest * make requestObjective an internal type * make requestObjective an internal type 2 * make requestObjective an internal type 3 * make requestObjective an internal type 4 * make requestObjective an internal type 5 * add PopulateControllerConfig to runner
* add priority to admit request * add inference obj spec to llmrequest * make requestObjective an internal type * make requestObjective an internal type 2 * make requestObjective an internal type 3 * make requestObjective an internal type 4 * make requestObjective an internal type 5 * add PopulateControllerConfig to runner
This pull request introduces an important update to the
Runner's startup process inrunner.go. The main change ensures that the controller configuration is properly populated and validated before proceeding, improving error handling and startup reliability. Currently CRDs like inferenceobjective and inferenceModelRewrite is not being read by EPP during startup.Key improvement to controller configuration:
PopulateControllerConfigoncontrollerCfg, which now validates and populates the controller configuration using the providedcfg. If this step fails, an error is logged and the startup process is halted to prevent misconfiguration.