Skip to content

add PopulateControllerConfig in runner.go#2300

Merged
k8s-ci-robot merged 9 commits intokubernetes-sigs:mainfrom
tomatillo-and-multiverse:main
Feb 10, 2026
Merged

add PopulateControllerConfig in runner.go#2300
k8s-ci-robot merged 9 commits intokubernetes-sigs:mainfrom
tomatillo-and-multiverse:main

Conversation

@kaushikmitr
Copy link
Copy Markdown
Contributor

This pull request introduces an important update to the Runner's startup process in runner.go. The main change ensures that the controller configuration is properly populated and validated before proceeding, improving error handling and startup reliability. Currently CRDs like inferenceobjective and inferenceModelRewrite is not being read by EPP during startup.

Key improvement to controller configuration:

  • Added a call to PopulateControllerConfig on controllerCfg, which now validates and populates the controller configuration using the provided cfg. If this step fails, an error is logged and the startup process is halted to prevent misconfiguration.

@netlify
Copy link
Copy Markdown

netlify bot commented Feb 9, 2026

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit e9537d4
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/698a5b46917a010008bb8151
😎 Deploy Preview https://deploy-preview-2300--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 9, 2026
@ahg-g
Copy link
Copy Markdown
Contributor

ahg-g commented Feb 10, 2026

The PR that introduced this bug is #1967; and so it is impacting the last release @kfswain ; basically the last release infObj and modelNameRewrite are not working. @zetxqx this mean we don't have proper test coverage, an integration test should catch this.

@ahg-g
Copy link
Copy Markdown
Contributor

ahg-g commented Feb 10, 2026

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 10, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, kaushikmitr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 10, 2026
@ahg-g
Copy link
Copy Markdown
Contributor

ahg-g commented Feb 10, 2026

/retest

@k8s-ci-robot k8s-ci-robot merged commit 05f1b95 into kubernetes-sigs:main Feb 10, 2026
11 checks passed
@elevran
Copy link
Copy Markdown
Contributor

elevran commented Feb 11, 2026

is a patch release planned?

@kfswain
Copy link
Copy Markdown
Collaborator

kfswain commented Feb 13, 2026

/cherrypick release-1.3

@k8s-infra-cherrypick-robot
Copy link
Copy Markdown

@kfswain: #2300 failed to apply on top of branch "release-1.3":

Applying: add priority to admit request
Using index info to reconstruct a base tree...
A	pkg/epp/framework/interface/requestcontrol/plugins.go
M	pkg/epp/requestcontrol/director.go
M	pkg/epp/requestcontrol/director_test.go
M	pkg/epp/requestcontrol/request_control_config.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/epp/requestcontrol/request_control_config.go
Auto-merging pkg/epp/requestcontrol/plugins.go
CONFLICT (content): Merge conflict in pkg/epp/requestcontrol/plugins.go
Auto-merging pkg/epp/requestcontrol/director_test.go
CONFLICT (content): Merge conflict in pkg/epp/requestcontrol/director_test.go
Auto-merging pkg/epp/requestcontrol/director.go
CONFLICT (content): Merge conflict in pkg/epp/requestcontrol/director.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 add priority to admit request

Details

In response to this:

/cherrypick release-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

kfswain pushed a commit that referenced this pull request Feb 14, 2026
* add priority to admit request

* add inference obj spec to llmrequest

* make requestObjective an internal type

* make requestObjective an internal type 2

* make requestObjective an internal type 3

* make requestObjective an internal type 4

* make requestObjective an internal type 5

* add PopulateControllerConfig to runner
RyanRosario pushed a commit to RyanRosario/gateway-api-inference-extension that referenced this pull request Mar 9, 2026
* add priority to admit request

* add inference obj spec to llmrequest

* make requestObjective an internal type

* make requestObjective an internal type 2

* make requestObjective an internal type 3

* make requestObjective an internal type 4

* make requestObjective an internal type 5

* add PopulateControllerConfig to runner
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants