Skip to content

conformance: modify warmup from weighted two-pools test#2316

Merged
k8s-ci-robot merged 2 commits intokubernetes-sigs:mainfrom
danehans:issue_2315
Feb 12, 2026
Merged

conformance: modify warmup from weighted two-pools test#2316
k8s-ci-robot merged 2 commits intokubernetes-sigs:mainfrom
danehans:issue_2315

Conversation

@danehans
Copy link
Copy Markdown
Contributor

@danehans danehans commented Feb 11, 2026

What type of PR is this?

/kind flake

What this PR does / why we need it:

Modify the per-pod warmup loop in GatewayWeightedAcrossTwoInferencePools. The warmup used MakeRequestAndExpectEventuallyConsistentResponse (3 consecutive successes), which made requests targeting secondary endpoints probabilistic under 70/30 backendRef weighting and caused flakes.

Which issue(s) this PR fixes:

Fixes #2315

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added the kind/flake Categorizes issue or PR as related to a flaky test. label Feb 11, 2026
@netlify
Copy link
Copy Markdown

netlify bot commented Feb 11, 2026

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 8a49598
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/698e19e1492b460008f9d4a0
😎 Deploy Preview https://deploy-preview-2316--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@danehans danehans requested a review from zetxqx February 11, 2026 05:25
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 11, 2026
@danehans
Copy link
Copy Markdown
Contributor Author

Summarizing 1 Failure:
  [FAIL] InferencePool when The Inference Extension is running [It] Should expose EPP metrics after generating traffic
  /home/prow/go/src/sigs.k8s.io/gateway-api-inference-extension/test/e2e/epp/e2e_test.go:489
Ran 2 of 4 Specs in 375.600 seconds
FAIL! -- 1 Passed | 1 Failed | 0 Pending | 2 Skipped
--- FAIL: TestAPIs (375.60s)
FAIL
FAIL	sigs.k8s.io/gateway-api-inference-extension/test/e2e/epp	375.656s
FAIL
make: *** [Makefile:158: test-e2e] Error 1

/retest

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danehans, howardjohn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…s test

Drop the per-pod warmup loop in GatewayWeightedAcrossTwoInferencePools.
The warmup used MakeRequestAndExpectEventuallyConsistentResponse (3
consecutive successes), which made requests targeting secondary endpoints
probabilistic under 70/30 backendRef weighting and caused flakes.

Signed-off-by: Daneyon Hansen <daneyon.hansen@solo.io>
@zetxqx
Copy link
Copy Markdown
Contributor

zetxqx commented Feb 12, 2026

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 12, 2026
@k8s-ci-robot k8s-ci-robot merged commit 4b30384 into kubernetes-sigs:main Feb 12, 2026
11 checks passed
@danehans danehans deleted the issue_2315 branch February 12, 2026 18:51
@danehans danehans changed the title conformance: remove warmup from weighted two-pools test conformance: modify warmup from weighted two-pools test Feb 12, 2026
@kfswain
Copy link
Copy Markdown
Collaborator

kfswain commented Feb 13, 2026

/cherrypick release-1.3

@k8s-infra-cherrypick-robot
Copy link
Copy Markdown

@kfswain: #2316 failed to apply on top of branch "release-1.3":

Applying: conformance: remove warmup from GatewayWeightedAcrossTwoInferencePools test
Using index info to reconstruct a base tree...
M	conformance/tests/gateway_weighted_two_pools.go
Falling back to patching base and 3-way merge...
Auto-merging conformance/tests/gateway_weighted_two_pools.go
CONFLICT (content): Merge conflict in conformance/tests/gateway_weighted_two_pools.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 conformance: remove warmup from GatewayWeightedAcrossTwoInferencePools test

Details

In response to this:

/cherrypick release-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

kfswain pushed a commit that referenced this pull request Feb 14, 2026
* conformance: remove warmup from GatewayWeightedAcrossTwoInferencePools test

Drop the per-pod warmup loop in GatewayWeightedAcrossTwoInferencePools.
The warmup used MakeRequestAndExpectEventuallyConsistentResponse (3
consecutive successes), which made requests targeting secondary endpoints
probabilistic under 70/30 backendRef weighting and caused flakes.

Signed-off-by: Daneyon Hansen <daneyon.hansen@solo.io>

* conformance: add single deterministic warmup for weighted pools

---------

Signed-off-by: Daneyon Hansen <daneyon.hansen@solo.io>
RyanRosario pushed a commit to RyanRosario/gateway-api-inference-extension that referenced this pull request Mar 9, 2026
…igs#2316)

* conformance: remove warmup from GatewayWeightedAcrossTwoInferencePools test

Drop the per-pod warmup loop in GatewayWeightedAcrossTwoInferencePools.
The warmup used MakeRequestAndExpectEventuallyConsistentResponse (3
consecutive successes), which made requests targeting secondary endpoints
probabilistic under 70/30 backendRef weighting and caused flakes.

Signed-off-by: Daneyon Hansen <daneyon.hansen@solo.io>

* conformance: add single deterministic warmup for weighted pools

---------

Signed-off-by: Daneyon Hansen <daneyon.hansen@solo.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Conformance: GatewayWeightedAcrossTwoInferencePools Warmup is Probabilistic

6 participants